Unified Diff: locale/en-US/options.json
Issue 29321198:
Issue 2376 - Implement custom filters in new options page (Closed)
Patch Set:
Created June 29, 2015, 11:21 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« background.js ('K')
|
« background.js ('k')
|
messageResponder.js » ('j')
|
messageResponder.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: locale/en-US/options.json |
| =================================================================== |
| --- a/locale/en-US/options.json |
| +++ b/locale/en-US/options.json |
| @@ -127,14 +127,26 @@ |
| "description": "Update button in Advanced tab", |
| "message": "Update all blocking lists" |
| }, |
| - "options_blockingRules": { |
| - "description": "Own blicking list header in Advanced tab", |
| + "options_customFilters_title": { |
| + "description": "Option name in Advanced tab", |
|
Thomas Greiner
2015/06/30 09:23:26
Which option?
saroyanm
2015/07/08 18:25:39
For some option names we are specifying for some n
Thomas Greiner
2015/07/09 11:07:54
Awesome, thanks.
|
| "message": "Blocking rules" |
| }, |
| - "options_blockingRules_edit": { |
| - "description": "Edit rules button in Advanced tab", |
| + "options_customFilters_textbox_placeholder": { |
| + "description": "Placeholder text in Advanced tab", |
|
Thomas Greiner
2015/06/30 09:23:26
Placeholder text for what?
saroyanm
2015/07/08 18:25:39
Done.
|
| + "message": "add your blocking rule here" |
| + }, |
| + "options_customFilter_edit_btn": { |
|
Thomas Greiner
2015/06/30 09:23:26
The "_btn" at the end is not necessary for it to b
saroyanm
2015/07/08 18:25:39
Done.
|
| + "description": "Button label in Advanced tab", |
|
Thomas Greiner
2015/06/30 09:23:26
Suggestion: "Label for editing custom filter in Ad
saroyanm
2015/07/08 18:25:39
Done, better.
|
| "message": "edit rules" |
| }, |
| + "options_customFilter_list_btn": { |
| + "description": "Button label in Advanced tab", |
| + "message": "list view" |
| + }, |
| + "options_customFilter_save_btn": { |
| + "description": "Button label in Advanced tab", |
| + "message": "Save" |
|
Thomas Greiner
2015/06/30 09:23:26
Why is "Save" upper-case while "list view" is lowe
saroyanm
2015/07/08 18:25:39
Done.
|
| + }, |
| "options_faq_title": { |
| "description": "FAQ section name in Help tab and link label in same section", |
| "message": "Frequently asked questions" |
« background.js ('K')
|
« background.js ('k')
|
messageResponder.js » ('j')
|
messageResponder.js » ('J')
