Issue 2376 - Implement custom filters in new options page

skin/options.css

Index: skin/options.css
===================================================================
--- a/skin/options.css
+++ b/skin/options.css
@@ -54,6 +54,13 @@
   display: none;
 }
 
+input[type="text"], input[type="search"]
+{
+  -webkit-box-sizing: border-box;
+  -moz-box-sizing: border-box;
+  box-sizing: border-box;

[Thomas Greiner, 2015/06/30 09:23:29]

What about applying `box-sizing:border-box` to every element on the page to
ensure consistency? Because I guess that's quite a common problem.

[saroyanm, 2015/07/08 18:25:43]

I think it make sense to create a separate ticket for that. It will need some
additional fixes on layout.

[Thomas Greiner, 2015/07/09 11:07:54]

Fine with me.

+}
+
 .option-name
 {
   display: flex;
@@ -422,7 +429,8 @@
 }
 
 .icon, .table input[type="checkbox"]::before, .table button.delete,
-#content-help a::before, #dialog-close::before
+#content-help a::before, #dialog-close::before,
+#custom-filters-add-btn::after
 {
   background-image: url(options-sprite.png);
   display: inline-block;
@@ -537,7 +545,7 @@
   outline: 0px;
   padding-bottom: 5px;
   vertical-align: text-bottom;
-  width: 330px;
+  width: 355px;

[Thomas Greiner, 2015/06/30 09:23:30]

Could you please try making this more dynamic instead of hard-coding the pixel
value?

[saroyanm, 2015/07/08 18:25:42]

Done, but I do not understand why it's overlapping to the icon when mangin-start
is 14px. Do you have idea why it's overlapping ?

[Thomas Greiner, 2015/07/09 11:07:55]

It seems that #whitelisting-add-icon's width is lower than 18px for some reason
so you need to specify min-width on it.

[saroyanm, 2015/07/09 16:31:40]

Done.

 }
 
 #whitelisting .controls .button-add span
@@ -581,65 +589,132 @@
   Advanced tab content
 */
 
-#blocking-list-own .table
+#custom-filters-header
+{
+  -moz-margin-start: 20px;
+  -webkit-margin-start: 20px;

[Thomas Greiner, 2015/06/30 09:23:29]

What about `padding: 0px 20px;` instead? We want to have the same distance on
either side anyway.

[saroyanm, 2015/07/08 18:25:43]

Done.

+  margin-bottom: 10px;
+}
+
+#custom-filters-textarea-controls, #custom-filters-edit-btn,
+#custom-filters-list-wrapper, #custom-filters-textarea
+{
+  display: none;
+}
+
+#custom-filters[data-view="edit"] #custom-filters-textarea,
+#custom-filters[data-view="list"] #custom-filters-edit-btn,
+#custom-filters[data-view="list"] #custom-filters-list-wrapper

[Thomas Greiner, 2015/06/30 09:23:29]

You could combine this, the block above and the block below into this cleaner
construct:

#custom-filters-textarea-controls
{
  display: flex;
}

#custom-filters:not(.mode-edit) #custom-filters-textarea-controls,
#custom-filters:not(.mode-edit) #custom-filters-textarea,
#custom-filters.mode-edit #custom-filters-edit-btn,
#custom-filters.mode-edit #custom-filters-list-wrapper
{
  display: none;
}

[saroyanm, 2015/07/08 18:25:42]

Done.

+{
+  display: block;
+}
+
+#custom-filters[data-view="edit"] #custom-filters-textarea-controls
+{
+  display: flex;
+}
+
+#custom-filters-save-btn
+{
+  -moz-margin-start: 16px;
+  -webkit-margin-start: 16px;

[Thomas Greiner, 2015/06/30 09:23:30]

Again, what about `padding: 0px 16px;` instead?

[saroyanm, 2015/07/08 18:25:42]

Done.

+}
+
+#custom-filters .table
 {
   height: 290px;
   overflow: auto;
   width: auto;
 }
 
-#blocking-list-own .controls
+#custom-filter-add-wrapper
 {
   display: flex;
   padding: 0px;
   border: none;
 }
 
-#blocking-list-own input[type="text"],
-#blocking-list-own input[type="text"]:focus
+#custom-filters .controls
 {
-  border: 0px;
-  border-bottom: 1px solid;
-  border-top: 1px solid;
+  border-top: none;
+}
+
+#custom-filters-textarea
+{
+  width: 100%;
+  height: 328px;

[Thomas Greiner, 2015/06/30 09:23:30]

I assume you'll make this pixel value more dynamic with the tabs implementation
in #2375?

[saroyanm, 2015/07/08 18:25:43]

Couldn't find better way to achieve this, currently it's getting the height of
the wrapper, but please note that the list view table's height is hardcoded.

+}
+
+#custom-filters input[type="text"],
+#custom-filters input[type="text"]:focus

[Thomas Greiner, 2015/06/30 09:23:29]

Please split up those two styles. I assume `:focus` only needs `outline:0px`.

[saroyanm, 2015/07/08 18:25:42]

Done.

+{
+  border-width: 1px 0px 1px 0px;
+  border-bottom-style: solid;
+  border-top-style: solid;
   border-color: #1E8728;
-  box-sizing: border-box;
   height: 25px;
   outline: 0px;
   -moz-padding-start: 10px;
   -webkit-padding-start: 10px;
+  -moz-padding-end: 60px;
+  -webkit-padding-end: 60px;
+  padding-top: 18px;
+  padding-bottom: 18px;
   width: 100%;
 }
 
-.icon-enter-blue
+#custom-filters-add-textbox
 {
-  background-position: -28px -85px;
-  cursor: pointer;
-  height: 10px;
-  margin: 0px 0px -2px 2px;
-  width: 10px;
+  font-size: 13px;

[Thomas Greiner, 2015/06/30 09:23:30]

Missing background color which is specified in design mockup.

[saroyanm, 2015/07/08 18:25:42]

Done.

 }
 
-#blocking-list-own .input-control
+#custom-filters-add-textbox::-webkit-input-placeholder
 {
-  position: absolute;
-  -webkit-margin-start: -50px;
-  -moz-margin-start: -50px;
-  bottom: 5px;
+  font-weight: bold;

[Thomas Greiner, 2015/06/30 09:23:29]

Actually, we don't have fonts for bold (= `font-weight:700`), only for semi-bold
(= `font-weight:600`) so I'd generally suggest to exclusively use integers to
specify font weights.

[saroyanm, 2015/07/08 18:25:43]

Done.

+}
+#custom-filters-add-textbox::-moz-placeholder
+{
+  font-weight: bold;
 }
 
-#blocking-list-own .input-separator
+#custom-filters-table
 {
+  border-top: 1px solid #CDCDCD;
+}
+
+#custom-filters-add-btn

[Thomas Greiner, 2015/06/30 09:23:29]

The add-button doesn't occupy the entire block it's contained in. Therefore if
you click slightly above the text, the action is not registered.

[saroyanm, 2015/07/08 18:25:42]

Done.

[Thomas Greiner, 2015/07/09 11:07:54]

It still doesn't register it when you click on the area to the right side of the
button. Adding `-x-padding-end` should be sufficient for that.

[saroyanm, 2015/07/09 16:31:40]

Done.

+{
+  font-size: 14px;
+  position: absolute;

[Thomas Greiner, 2015/06/30 09:23:29]

Doesn't this also work without `position:absolute` and `bottom:11px`?  Because
it seems like those don't do anything.

[saroyanm, 2015/07/08 18:25:42]

Exactly and they are fixing comment above :)

+  -webkit-margin-start: -60px;
+  -moz-margin-start: -60px;
+  bottom: 11px;
+  cursor: pointer;
+  color: #3A7BA6;
+}
+
+#custom-filters-add-btn::before
+{
+  content: "";
   display: inline-block;
   -moz-border-end: 1px solid #CDCDCD;
   -webkit-border-end: 1px solid #CDCDCD;
   height: 15px;
-  margin: 0px 4px -4px 0px;
+  -webkit-margin-end: 10px;
+  -moz-margin-end: 10px;
+  margin-bottom: -2px;
   width: 1px;
 }
 
-#blocking-list-own .input-button-text
+#custom-filters-add-btn::after

[saroyanm, 2015/06/29 11:34:18]

I do think we need to show icon for other buttons in similar way.
@Thomas please let me know if I need to create a ticket, in case it's not
covered in current ticket. 

[Thomas Greiner, 2015/06/30 09:23:29]

Yep, agreed. I guess you already confirmed in
https://codereview.adblockplus.org/29321206/diff/29321207/options.html#new-li...
that you'll create a ticket so fine with me.

 {
-  font-size: 12px;
+  content: "";
+  background-position: -28px -85px;
+  cursor: pointer;
+  height: 10px;
+  -webkit-margin-start: 6px;
+  -moz-margin-start: 6px;
+  width: 10px;
 }
 
 .tooltip, #block-element-explanation a
@@ -779,9 +854,6 @@
 #dialog input[type="text"],
 #dialog input[type="search"]
 {
-  -webkit-box-sizing: border-box;
-  -moz-box-sizing: border-box;
-  box-sizing: border-box;
   font-size: 16px;
   margin-top: 10px;
   padding: 5px;