Issue 2376 - Implement custom filters in new options page

background.js

Index: background.js
===================================================================
--- a/background.js
+++ b/background.js
@@ -153,6 +153,22 @@
     return new modules.filterClasses.Filter(text);
   };
 
+  modules.filterValidation = 
+  {
+    parseFilter: function(text) 
+    {
+      var filterError = {filterError: false};
+      updateFromURL(filterError);

[Thomas Greiner, 2015/07/15 08:32:35]

Add this parameter to the README.

[saroyanm, 2015/07/15 10:47:08]

Done.

+      if (filterError)

[Sebastian Noack, 2015/07/15 09:00:44]

This will always be true. It should be |filterError.filterError|. Or to make it
less confusing, you might want to rename the variable to "params":

  var params = {filterError: false};
  updateFromURL(params);
  if (params.filterError)
    ...

[saroyanm, 2015/07/15 10:47:11]

Done.

+        return {error: "Filter-parsing-error-occurred"};

[Thomas Greiner, 2015/07/15 08:32:36]

I'd suggest to use all lower-case for consistency and to remove the "-occured"
at the end because it's an ID, not a statement.

[saroyanm, 2015/07/15 10:47:08]

Done.

+      return {filter: modules.filterClasses.Filter.fromText(text)};
+    },
+    parseFilters: function(text)
+    {
+      return {filters: text.split("\n").map(modules.filterClasses.Filter.fromText)};

[Thomas Greiner, 2015/07/15 08:32:35]

This line exceeds the 80 characters limit.

[Sebastian Noack, 2015/07/15 09:00:44]

You don't consider the filter filterError URL parameter here.

[saroyanm, 2015/07/15 10:47:09]

Done.

[saroyanm, 2015/07/15 10:47:11]

Done.

+    }
+  };
+
   modules.synchronizer = {
     Synchronizer: {}
   };
@@ -221,7 +237,23 @@
     "@@||alternate.de^$document",
     "@@||der.postillion.com^$document", 
     "@@||taz.de^$document",
-    "@@||amazon.de^$document"
+    "@@||amazon.de^$document",
+    "||biglemon.am/bg_poster/banner.jpg",
+    "winfuture.de###header_logo_link",
+    "###WerbungObenRechts10_GesamtDIV",
+    "###WerbungObenRechts8_GesamtDIV",
+    "###WerbungObenRechts9_GesamtDIV",
+    "###WerbungUntenLinks4_GesamtDIV",
+    "###WerbungUntenLinks7_GesamtDIV",
+    "###WerbungUntenLinks8_GesamtDIV",
+    "###WerbungUntenLinks9_GesamtDIV",
+    "###Werbung_Sky",
+    "###Werbung_Wide",
+    "###__ligatus_placeholder__",
+    "###ad-bereich1-08",
+    "###ad-bereich1-superbanner",
+    "###ad-bereich2-08",
+    "###ad-bereich2-skyscrapper"
   ];
   var knownFilters = filters.map(modules.filterClasses.Filter.fromText);