Side by Side Diff: options.html
Issue 29321206:
Issue 2383 - Added links to options page sidebar (Closed)
Patch Set:
Created June 29, 2015, 1:55 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« locale/en-US/options.json ('k')
|
options.js » ('j')
|
options.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 - This file is part of Adblock Plus <https://adblockplus.org/>, | 3 - This file is part of Adblock Plus <https://adblockplus.org/>, |
| 4 - Copyright (C) 2006-2015 Eyeo GmbH | 4 - Copyright (C) 2006-2015 Eyeo GmbH |
| 5 - | 5 - |
| 6 - Adblock Plus is free software: you can redistribute it and/or modify | 6 - Adblock Plus is free software: you can redistribute it and/or modify |
| 7 - it under the terms of the GNU General Public License version 3 as | 7 - it under the terms of the GNU General Public License version 3 as |
| 8 - published by the Free Software Foundation. | 8 - published by the Free Software Foundation. |
| 9 - | 9 - |
| 10 - Adblock Plus is distributed in the hope that it will be useful, | 10 - Adblock Plus is distributed in the hope that it will be useful, |
| (...skipping 19 matching lines...) Expand all Loading... | |
| 30 <body data-tab="general"> | 30 <body data-tab="general"> |
| 31 <!-- Navigation sidebar --> | 31 <!-- Navigation sidebar --> |
| 32 <div id="nav-sidebar"> | 32 <div id="nav-sidebar"> |
| 33 <div id="fixed-sidebar" class="fixed"> | 33 <div id="fixed-sidebar" class="fixed"> |
| 34 <div id="page-title"> | 34 <div id="page-title"> |
| 35 <p class="i18n_options_page_header_1"></p> | 35 <p class="i18n_options_page_header_1"></p> |
| 36 <h1 class="i18n_options_page_header_2"></h1> | 36 <h1 class="i18n_options_page_header_2"></h1> |
| 37 </div> | 37 </div> |
| 38 <ul id="main-navigation-tabs" class="tabs vertical"> | 38 <ul id="main-navigation-tabs" class="tabs vertical"> |
| 39 <li id="tab-general" data-show="general" class="active"> | 39 <li id="tab-general" data-show="general" class="active"> |
| 40 <span class="i18n_options_tab_general"></span> | 40 <a class="i18n_options_tab_general"></a> |
|
saroyanm
2015/06/29 15:59:17
Can you please describe what is the reason of usin
Thomas Greiner
2015/06/29 16:34:11
Semantically, it's a link so we should use the app
saroyanm
2015/06/29 18:40:41
Fare enough.
| |
| 41 <span class="icon"></span> | 41 <span class="icon"></span> |
| 42 </li> | 42 </li> |
| 43 <li id="tab-advanced" data-show="advanced"> | 43 <li id="tab-advanced" data-show="advanced"> |
| 44 <span class="i18n_options_tab_advanced"></span> | 44 <a class="i18n_options_tab_advanced"></a> |
| 45 <span class="icon"></span> | 45 <span class="icon"></span> |
| 46 </li> | 46 </li> |
| 47 <li id="tab-help" data-show="help"> | 47 <li id="tab-help" data-show="help"> |
| 48 <span class="i18n_options_tab_help"></span> | 48 <a class="i18n_options_tab_help"></a> |
| 49 <span class="icon"></span> | 49 <span class="icon"></span> |
| 50 </li> | 50 </li> |
| 51 </ul> | 51 </ul> |
| 52 <p class="nav-link"> | 52 <a id="link-version"> |
| 53 <span class="i18n_options_version"></span> <span id="abp-version"></sp an> | 53 <span class="i18n_options_version"></span> |
| 54 </p> | 54 <span id="abp-version"></span> |
| 55 </a> | |
| 55 <ul class="tabs vertical bottom"> | 56 <ul class="tabs vertical bottom"> |
| 56 <li id="tab-share"> | 57 <li id="tab-share"> |
| 57 <span class="i18n_options_tab_share"></span><span class="icon"></spa n> | 58 <a class="i18n_options_tab_share"></a> |
| 59 <span class="icon"></span> | |
| 58 </li> | 60 </li> |
| 59 <li id="tab-donate"> | 61 <li id="tab-contribute"> |
| 60 <span class="i18n_options_tab_donate"></span><span class="icon"></sp an> | 62 <a class="i18n_options_tab_contribute"></a> |
| 63 <span class="icon"></span> | |
| 61 </li> | 64 </li> |
| 62 </ul> | 65 </ul> |
| 63 </div> | 66 </div> |
| 64 </div> | 67 </div> |
| 65 <div id="tab-content"> | 68 <div id="tab-content"> |
| 66 <div id="content-wrapper"> | 69 <div id="content-wrapper"> |
| 67 <div id="dialog-background"></div> | 70 <div id="dialog-background"></div> |
| 68 | 71 |
| 69 <!-- General tab content --> | 72 <!-- General tab content --> |
| 70 <div id="content-general"> | 73 <div id="content-general"> |
| (...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 303 <h3 class="i18n_options_dialog_edit_own_list"></h3> | 306 <h3 class="i18n_options_dialog_edit_own_list"></h3> |
| 304 <div id="edit-ownBlockingList-button" class="button-wrapper"> | 307 <div id="edit-ownBlockingList-button" class="button-wrapper"> |
| 305 <span class="icon icon-arrow"></span> | 308 <span class="icon icon-arrow"></span> |
| 306 <span class="i18n_options_dialog_create_own_list"></span> | 309 <span class="i18n_options_dialog_create_own_list"></span> |
| 307 </div> | 310 </div> |
| 308 </div> | 311 </div> |
| 309 </div> | 312 </div> |
| 310 </div> | 313 </div> |
| 311 </div> | 314 </div> |
| 312 </body> | 315 </body> |
| 313 </html> | 316 </html> |
| OLD | NEW |
« no previous file with comments
|
« locale/en-US/options.json ('k')
|
options.js » ('j')
|
options.js » ('J')
