Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: options.js

Issue 29321206: Issue 2383 - Added links to options page sidebar (Closed)
Left Patch Set: Created June 29, 2015, 1:55 p.m.
Right Patch Set: Created June 29, 2015, 4:31 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « options.html ('k') | skin/options.css » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2015 Eyeo GmbH 3 * Copyright (C) 2006-2015 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 615 matching lines...) Expand 10 before | Expand all | Expand 10 after
626 }); 626 });
627 } 627 }
628 628
629 function E(id) 629 function E(id)
630 { 630 {
631 return document.getElementById(id); 631 return document.getElementById(id);
632 } 632 }
633 633
634 function getDocLink(link, callback) 634 function getDocLink(link, callback)
635 { 635 {
636 ext.backgroundPage.sendMessage({ 636 ext.backgroundPage.sendMessage(
saroyanm 2015/06/29 15:59:17 nit: please place the opening curly bracket in the
Thomas Greiner 2015/06/29 16:34:11 I changed it but seeing that it's done differently
saroyanm 2015/06/29 18:40:41 Good point, will create ticket for that.
637 {
637 type: "app.get", 638 type: "app.get",
638 what: "doclink", 639 what: "doclink",
639 link: link 640 link: link
640 }, callback); 641 }, callback);
641 } 642 }
642 643
643 ext.onMessage.addListener(function(message) 644 ext.onMessage.addListener(function(message)
644 { 645 {
645 switch (message.type) 646 switch (message.type)
646 { 647 {
(...skipping 21 matching lines...) Expand all
668 filter: ["added", "loaded", "removed"] 669 filter: ["added", "loaded", "removed"]
669 }); 670 });
670 ext.backgroundPage.sendMessage( 671 ext.backgroundPage.sendMessage(
671 { 672 {
672 type: "subscriptions.listen", 673 type: "subscriptions.listen",
673 filter: ["added", "disabled", "homepage", "removed", "title"] 674 filter: ["added", "disabled", "homepage", "removed", "title"]
674 }); 675 });
675 676
676 window.addEventListener("DOMContentLoaded", onDOMLoaded, false); 677 window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
677 })(); 678 })();
LEFTRIGHT

Powered by Google App Engine
This is Rietveld