Issue 2383 - Added links to options page sidebar

options.html

Index: options.html
===================================================================
--- a/options.html
+++ b/options.html
@@ -37,27 +37,30 @@
         </div>
         <ul id="main-navigation-tabs" class="tabs vertical">
           <li id="tab-general" data-show="general" class="active">
-            <span class="i18n_options_tab_general"></span>
+            <a class="i18n_options_tab_general"></a>

[saroyanm, 2015/06/29 15:59:17]

Can you please describe what is the reason of using <a> tags instead of  <span>
here ?
And how are this changes connected with current issue ?
Also I do think we will need to use ::after Pseudo element for the tab icons in
future.

[Thomas Greiner, 2015/06/29 16:34:11]

Semantically, it's a link so we should use the appropriate HTML element for
that. Furthermore this is a bit of preparation for #2409 to make those items
focusable.
Agree, but that's out of scope for this ticket.

[saroyanm, 2015/06/29 18:40:41]

Fare enough.
I just commenting to keep in mind.
Will create a ticket for that.

             <span class="icon"></span>
           </li>
           <li id="tab-advanced" data-show="advanced">
-            <span class="i18n_options_tab_advanced"></span>
+            <a class="i18n_options_tab_advanced"></a>
             <span class="icon"></span>
           </li>
           <li id="tab-help" data-show="help">
-            <span class="i18n_options_tab_help"></span>
+            <a class="i18n_options_tab_help"></a>
             <span class="icon"></span>
           </li>
         </ul>
-        <p class="nav-link">
-          <span class="i18n_options_version"></span> <span id="abp-version"></span>
-        </p>
+        <a id="link-version">
+          <span class="i18n_options_version"></span>
+          <span id="abp-version"></span>
+        </a>
         <ul class="tabs vertical bottom">
           <li id="tab-share">
-            <span class="i18n_options_tab_share"></span><span class="icon"></span>
+            <a class="i18n_options_tab_share"></a>
+            <span class="icon"></span>
           </li>
-          <li id="tab-donate">
-            <span class="i18n_options_tab_donate"></span><span class="icon"></span>
+          <li id="tab-contribute">
+            <a class="i18n_options_tab_contribute"></a>
+            <span class="icon"></span>
           </li>
         </ul>
       </div>
@@ -310,4 +313,4 @@
       </div>
     </div>
   </body>
-</html>
+</html>