Issue 2735 - Use ensure_dependencies.py in adblockplusie

createsolution.bat

Index: createsolution.bat
===================================================================
--- a/createsolution.bat
+++ b/createsolution.bat
@@ -5,6 +5,9 @@
 if "%type%"=="" set type=devbuild
 
 pushd %~dp0
+
+python ensure_dependencies.py

[sergei, 2015/06/30 09:51:06]

It means that git users won't be able even to generate solution.

[Eric, 2015/07/01 16:58:27]

The way this is written, it means mandatory network activity every time you
create solutions. I am very much against that. It's OK as default behavior,
because newcomers to the code won't know to run this script.

But I don't want the delay every time I fiddle with the gyp file. For example,
in the last week I've been switching tool sets back and forth on one project for
testing purposes. I'm running createsolutions all the time. I really don't want
to be constantly checking repositories for things that aren't changing.

So we need an option here to suppress checking dependencies. Alternately, we
could run ensure_dependencies with an option that does only a sanity check, and
prints out an error message if that fails so that a new user can run
ensure_dependencies manually.

[Felix Dahlke, 2015/07/02 10:02:06]

While I agree that this is not too straightforward, there wouldn't actually be
mandatory network activity: The script does nothing if you're already on the
desired revision (i.e. the one from the dependencies file). It only pulls if
necessary.
That's what the SKIP_ENSURE_DEPENDENCIES environment variable does (in newer
versions of the script). If set, the script will only check if the user is on
the desired revision and print a warning if he isn't, but it won't attempt any
downloads.

This still is problematic for people that don't have hg/git in the path. But I'd
prefer to tackle this issue as a follow-up (we should file a defect for that,
because it's a common situation for MSYS Git users).

Should be OK the way it's integrated here, the script should continue even if
ensure_dependencies.py fails, for whatever reason.

[Eric, 2015/07/04 16:46:46]

OK. That's not obvious from the code. (I didn't read it long enough to determine
this.) A description of this behavior really ought to be part of the
documentation for the script.

+
 if NOT EXIST build\ia32\libadblockplus\shell\nul mkdir build\ia32\libadblockplus\shell
 if NOT EXIST build\x64\libadblockplus\shell\nul mkdir build\x64\libadblockplus\shell