Issue 2381 - Added share overlay to options page

options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 645 matching lines @@
           }
           updateShareLink();
         });
         break;
       case "title":
         // TODO: NYI
         break;
     }
   }
 
+  function onShareLinkClick(e)
+  {
+    e.preventDefault();
+
+    getDocLink("share-general", function(link)
+    {
+      openSharePopup(link);
+    });
+  }
+
   function updateShareLink()

[saroyanm, 2015/09/08 17:33:49]

Shouldn't this implementation also be shared between scripts ?

[Thomas Greiner, 2015/09/23 14:03:05]

No, the difference is that on the first-run page we check for a specific
resource while here we check for all three of them.

The reason for that is that we still want to show the share overlay when someone
clicks on the Twitter button even if the Facebook script is blocked.

   {
-    ext.backgroundPage.sendMessage(
+    var shareResources = [
+      "https://facebook.com/plugins/like.php?",
+      "https://platform.twitter.com/widgets/",
+      "https://apis.google.com/se/0/_/+1/fastbutton?"
+    ];
+    var isAnyBlocked = false;
+    var checksRemaining = shareResources.length;
+
+    function onResult(isBlocked)
     {
-      type: "filters.blocked",
-      url: "https://platform.twitter.com/widgets/",
-      requestType: "SCRIPT",
-      docDomain: "adblockplus.org",
-      thirdParty: true
-    },
-    function(blocked)
-    {
-      // TODO: modify "share" link accordingly
-    });
-  }
+      isAnyBlocked |= isBlocked;
+      if (!--checksRemaining)
+      {
+        // Hide the share tab if a script on the share page would be blocked
+        var tab = E("tab-share");
+        if (isAnyBlocked)
+        {
+          tab.hidden = true;
+          tab.removeEventListener("click", onShareLinkClick, false);
+        }
+        else
+          tab.addEventListener("click", onShareLinkClick, false);
+      }
+    }
 
-  function E(id)
-  {
-    return document.getElementById(id);
-  }
-
-  function getDocLink(link, callback)
-  {
-    ext.backgroundPage.sendMessage(
-    {
-      type: "app.get",
-      what: "doclink",
-      link: link
-    }, callback);
+    for (var i = 0; i < shareResources.length; i++)
+      checkShareResource(shareResources[i], onResult);
   }
 
   ext.onMessage.addListener(function(message)
   {
     switch (message.type)
     {
       case "app.listen":
         if (message.action == "addSubscription")
         {
           var subscription = message.args[0];
@@ skipping 27 matching lines @@
     filter: ["added", "loaded", "removed"]
   });
   ext.backgroundPage.sendMessage(
   {
     type: "subscriptions.listen",
     filter: ["added", "disabled", "homepage", "removed", "title"]
   });
 
   window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 })();