Issue 2381 - Added share overlay to options page

common.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
+
+"use strict";
 

[saroyanm, 2015/09/08 17:33:49]

I think we should use "strict" here as well, but not sure why it's missing in
background.js and i18n.js ? Is there a reason, or we forget to add ? 

[Thomas Greiner, 2015/09/23 14:03:05]

The reason for that is that adding strict mode after the fact can cause
unexpected errors. Since most of this code comes from a file that didn't use
strict mode before, I didn't add it.

Anyway, I tested all functions in this file now and added the statement.

 (function(global)
 {
   global.E = function E(id)
   {
     return document.getElementById(id);
   }
 
   global.getDocLink = function(link, callback)
   {
     ext.backgroundPage.sendMessage({
@@ skipping 84 matching lines @@
       {
         var rootElement = iframe.contentDocument.documentElement;
         var width = rootElement.dataset.width;
         var height = rootElement.dataset.height;
         if (width && height)
           resizePopup(width, height);
       }
 
       if (popupMessageReceived)
       {
         iframe.className = "visible";

[saroyanm, 2015/09/08 17:33:49]

This implementation is inconsistent, with other similar implementation on the
page, but it's not the part of the review and it just about reuse the overlay,
so we can fix this also afterward.

[Thomas Greiner, 2015/09/23 14:03:05]

Agreed, let's work on consistency changes separately.

 
         var popupCloseListener = function()
         {
           iframe.className = glassPane.className = "";
           document.removeEventListener("click", popupCloseListener);
         };
         document.addEventListener("click", popupCloseListener, false);
       }
       else
       {
         glassPane.className = "";
         window.removeEventListener("message", popupMessageListener);
       }
 
       iframe.removeEventListener("load", popupLoadListener);
     };
     iframe.addEventListener("load", popupLoadListener, false);
 
     iframe.src = url;
     glassPane.className = "visible";
   }
 })(this);