Issue 2600 - Normalize ownership and priviliges for Nginx logs

modules/nginx/manifests/init.pp

Index: modules/nginx/manifests/init.pp
===================================================================
--- a/modules/nginx/manifests/init.pp
+++ b/modules/nginx/manifests/init.pp
@@ -119,6 +119,13 @@
     require => Package['nginx']
   }
 
+  exec {"set_logfiles_owner_and_permissions":
+    command => '/bin/chown www-data.adm /var/log/nginx/* && /bin/chmod 0640 /var/log/nginx/*',

[mathias, 2015/07/03 13:51:04]

Except for intermediate fixes, please do not use shell commands - especially not
with logic operators (&&). By the way, there's no need to make the chmod
dependent on a successful chown here. Why not just creating two exec's?

Also, the asterisk wildcard can very well lead to more issues; it may expand to
either unrecognized sub-directories or, altogether, in a too long command line.
What about `find /var/log/nginx -mindepth 1 ... -exec ...`?

And please take the user from $nginx::params::user (the group can remain
hard-coded). Have a look at the shellquote() function at
https://docs.puppetlabs.com/references/latest/function.html#shellquote - it's
the best way to integrate parameters (like the user name) with your command.

[Fred, 2015/07/06 16:11:52]

Acknowledged.

+    # this should all be provided by package nginx:
+    # require => [File['/var/log/nginx'], User['www-data'], Group['adm']]

[mathias, 2015/07/03 13:51:04]

This comment is both wrong (neither User['www-data'] nor Group['adm'] is
provided by Package['nginx']) and unnecessary. The require parameter below
should say enough.

[Fred, 2015/07/06 16:11:52]

Acknowledged.

+    require => Package['nginx']

[mathias, 2015/07/03 13:51:04]

Please always use trailing commas, even when defining the last item. (I know
this has been forgotten before, even in this file.)

[Fred, 2015/07/06 16:11:52]

Acknowledged.

+  }
+
   service {'nginx':
     ensure => running,
     enable => true,