Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Side by Side Diff: options.html

Issue 29321417: Issue 2357 - Added "predefined list" dialog to options page (Closed)
Patch Set: Replaced dataset with has/get/set/removeAttribute Created July 10, 2015, 2:18 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« locale/en-US/options.json ('K') | « locale/en-US/options.json ('k') | options.js » ('j') | options.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-2015 Eyeo GmbH 4 - Copyright (C) 2006-2015 Eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 <span class="i18n_options_language_title"></span> 79 <span class="i18n_options_language_title"></span>
80 <a class="i18n_options_readMore tooltip" target="_blank"></a> 80 <a class="i18n_options_readMore tooltip" target="_blank"></a>
81 </p> 81 </p>
82 <ul id="blocking-languages-table" class="table list"> 82 <ul id="blocking-languages-table" class="table list">
83 <template> 83 <template>
84 <input type="checkbox" class="control" /> 84 <input type="checkbox" class="control" />
85 <span class="display"></span> 85 <span class="display"></span>
86 </template> 86 </template>
87 </ul> 87 </ul>
88 <div class="controls"> 88 <div class="controls">
89 <button id="add-website-language"> 89 <button data-action="open-language-dialog">
90 <span class="icon icon-add"></span> 90 <span class="icon icon-add"></span>
91 <span class="i18n_options_language_add"></span> 91 <span class="i18n_options_language_add"></span>
92 </button> 92 </button>
93 </div> 93 </div>
94 </div> 94 </div>
95 <div id="further-blocking"> 95 <div id="further-blocking">
96 <p class="option-name"> 96 <p class="option-name">
97 <strong class="i18n_options_furtherBlocking_title"></strong> 97 <strong class="i18n_options_furtherBlocking_title"></strong>
98 <a class="i18n_options_readMore tooltip" target="_blank"></a> 98 <a class="i18n_options_readMore tooltip" target="_blank"></a>
99 </p> 99 </p>
100 <div id="custom-wrapper"> 100 <div id="custom-wrapper">
101 <ul id="recommend-list-table" class="table list"> 101 <ul id="recommend-list-table" class="table list">
102 <template> 102 <template>
103 <input type="checkbox" class=control /> 103 <input type="checkbox" class=control />
104 <span class="display"></span> 104 <span class="display"></span>
105 <span class="popular"></span> 105 <span class="popular"></span>
106 </template> 106 </template>
107 </ul> 107 </ul>
108 <ul id="custom-list-table" class="table list"> 108 <ul id="custom-list-table" class="table list">
109 <template> 109 <template>
110 <input type="checkbox" class="control" /> 110 <input type="checkbox" class="control" />
111 <span class="display"></span> 111 <span class="display"></span>
112 </template> 112 </template>
113 </ul> 113 </ul>
114 </div> 114 </div>
115 <div class="controls"> 115 <div class="controls">
116 <button id="add-blocking-list"> 116 <button data-action="open-subscription-dialog">
117 <span class="icon icon-add"></span> 117 <span class="icon icon-add"></span>
118 <span class="i18n_options_furtherBlocking_add"><span> 118 <span class="i18n_options_furtherBlocking_add"><span>
119 </button> 119 </button>
120 </div> 120 </div>
121 </div> 121 </div>
122 </div> 122 </div>
123 </div> 123 </div>
124 <div> 124 <div>
125 <h1 class="i18n_options_exceptions_title"></h1> 125 <h1 class="i18n_options_exceptions_title"></h1>
126 <div class="flex-container"> 126 <div class="flex-container">
(...skipping 15 matching lines...) Expand all
142 <a class="i18n_options_readMore tooltip" target="_blank"></a> 142 <a class="i18n_options_readMore tooltip" target="_blank"></a>
143 </p> 143 </p>
144 <ul id="whitelisting-table" class="table list"> 144 <ul id="whitelisting-table" class="table list">
145 <template> 145 <template>
146 <button class="delete control"></button> 146 <button class="delete control"></button>
147 <span class="display"></span> 147 <span class="display"></span>
148 </template> 148 </template>
149 </ul> 149 </ul>
150 <div class="controls"> 150 <div class="controls">
151 <div> 151 <div>
152 <span id="whitelisting-add-icon" class="icon icon-add"></spa n> 152 <span class="icon icon-add" data-action="add-domain-exceptio n"></span>
153 <input type="text" id="whitelisting-textbox" /> 153 <input type="text" id="whitelisting-textbox" />
154 <span id="whitelisting-enter-icon" class="icon icon-enter">< /span> 154 <span class="icon icon-enter" data-action="add-domain-except ion"></span>
155 </div> 155 </div>
156 <div> 156 <div>
157 <button id="whitelisting-add-button" class="button-add"> 157 <button id="whitelisting-add-button" class="button-add" data -action="add-domain-exception">
158 +<span class="i18n_options_button_add"></span> 158 +<span class="i18n_options_button_add"></span>
159 </button> 159 </button>
160 <span></span> 160 <span></span>
161 <button id="whitelisting-cancel-button" class="i18n_options_ button_cancel cancel-button"></button> 161 <button class="i18n_options_button_cancel cancel-button" dat a-action="cancel-domain-exception"></button>
162 </div> 162 </div>
163 </div> 163 </div>
164 </div> 164 </div>
165 </div> 165 </div>
166 </div> 166 </div>
167 </div> 167 </div>
168 168
169 <!-- Advanced tab content --> 169 <!-- Advanced tab content -->
170 <div id="content-advanced"> 170 <div id="content-advanced">
171 <div> 171 <div>
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 </div> 254 </div>
255 </div> 255 </div>
256 </div> 256 </div>
257 257
258 <!-- Dialog --> 258 <!-- Dialog -->
259 <div id="dialog"> 259 <div id="dialog">
260 <header> 260 <header>
261 <span id="dialog-title"> 261 <span id="dialog-title">
262 <span id="dialog-title-customlist" class="i18n_options_dialog_customli st_title"></span> 262 <span id="dialog-title-customlist" class="i18n_options_dialog_customli st_title"></span>
263 <span id="dialog-title-language" class="i18n_options_dialog_language_t itle"></span> 263 <span id="dialog-title-language" class="i18n_options_dialog_language_t itle"></span>
264 <span id="dialog-title-addSubscription" class="i18n_options_dialog_add Subscription_title"></span>
saroyanm 2015/07/13 16:20:07 I think make sense to have consistent IDs for each
Thomas Greiner 2015/07/13 18:37:14 Done but used different names to have shorter IDs.
264 </span> 265 </span>
265 <button id="dialog-close" class="i18n_options_close"></button> 266 <button id="dialog-close" class="i18n_options_close" data-action="close- dialog"></button>
266 </header> 267 </header>
267 <div id="dialog-body" class="content"> 268 <div id="dialog-body" class="content">
268 <!-- Add other website language: Dialog --> 269 <!-- Add other website language -->
269 <div id="dialog-content-language" class="dialog-content"> 270 <div id="dialog-content-language" class="dialog-content">
270 <div class="dialog-content-block"> 271 <div class="dialog-content-block">
271 <h3 class="i18n_options_dialog_language_added"></h3> 272 <h3 class="i18n_options_dialog_language_added"></h3>
272 <ul id="blocking-languages-dialog-table" class="table list"> 273 <ul id="blocking-languages-dialog-table" class="table list">
273 <template> 274 <template>
274 <span class="display"></span> 275 <span class="display"></span>
275 </template> 276 </template>
276 </ul> 277 </ul>
277 </div> 278 </div>
278 <div id="other-language" class="dialog-content-block"> 279 <div id="other-language" class="dialog-content-block">
279 <h3 class="i18n_options_dialog_language_other"></h3> 280 <h3 class="i18n_options_dialog_language_other"></h3>
280 <div> 281 <div>
281 <input type="search" id="find-language" /> 282 <input type="search" id="find-language" />
282 </div> 283 </div>
283 <ul id="all-lang-table" class="table list"> 284 <ul id="all-lang-table" class="table list">
284 <template> 285 <template>
285 <button class="button-add control"> 286 <button class="button-add control">
286 +<span></span> 287 +<span></span>
287 </button> 288 </button>
288 <span class="display"></span> 289 <span class="display"></span>
289 </template> 290 </template>
290 </ul> 291 </ul>
291 </div> 292 </div>
292 </div> 293 </div>
293 <!-- Add other blocking list: Dialog --> 294 <!-- Add other blocking list -->
294 <div id="dialog-content-customlist" class="dialog-content"> 295 <div id="dialog-content-customlist" class="dialog-content">
295 <div class="dialog-content-block"> 296 <div class="dialog-content-block">
296 <h3 class="i18n_options_dialog_customlist_subscription_title"></h3> 297 <h3 class="i18n_options_dialog_customlist_subscription_title"></h3>
297 <div> 298 <div>
298 <input id="blockingList-textbox" type="text" placeholder="www.exam ple.com/blockinglist.txt" /> 299 <input id="blockingList-textbox" type="text" placeholder="www.exam ple.com/blockinglist.txt" />
299 </div> 300 </div>
300 <div id="import-blockingList-button" class="button-wrapper"> 301 <div class="button-wrapper" data-action="import-subscription">
301 <span class="icon icon-arrow"></span> 302 <span class="icon icon-arrow"></span>
302 <span class="i18n_options_dialog_customlist_import"></span> 303 <span class="i18n_options_dialog_customlist_import"></span>
303 </div> 304 </div>
304 </div> 305 </div>
305 <div class="dialog-content-block"> 306 <div class="dialog-content-block">
306 <h3 class="i18n_options_dialog_edit_own_list"></h3> 307 <h3 class="i18n_options_dialog_edit_own_list"></h3>
307 <div id="edit-ownBlockingList-button" class="button-wrapper"> 308 <div class="button-wrapper" data-action="edit-custom-filters">
308 <span class="icon icon-arrow"></span> 309 <span class="icon icon-arrow"></span>
309 <span class="i18n_options_dialog_create_own_list"></span> 310 <span class="i18n_options_dialog_create_own_list"></span>
310 </div> 311 </div>
311 </div> 312 </div>
312 </div> 313 </div>
314 <!-- Add predefined subscription -->
315 <div id="dialog-content-addSubscription" class="dialog-content">
saroyanm 2015/07/13 16:20:07 As mentioned above, make sense to name our dialogs
Thomas Greiner 2015/07/13 18:37:14 Done.
316 <div class="dialog-content-block">
317 <h3></h3>
318 <div class="url"></div>
319 <div class="button-wrapper" data-action="add-subscription">
320 <span class="icon icon-arrow"></span>
321 <span class="i18n_options_dialog_addSubscription_confirm"></span>
322 </div>
323 </div>
324 </div>
313 </div> 325 </div>
314 </div> 326 </div>
315 </body> 327 </body>
316 </html> 328 </html>
OLDNEW
« locale/en-US/options.json ('K') | « locale/en-US/options.json ('k') | options.js » ('j') | options.js » ('J')

Powered by Google App Engine
This is Rietveld