Unified Diff: options.html
Issue 29321417:
Issue 2357 - Added "predefined list" dialog to options page (Closed)
Patch Set: Replaced dataset with has/get/set/removeAttribute
Created July 10, 2015, 2:18 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« locale/en-US/options.json ('K')
|
« locale/en-US/options.json ('k')
|
options.js » ('j')
|
options.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: options.html |
| =================================================================== |
| --- a/options.html |
| +++ b/options.html |
| @@ -86,7 +86,7 @@ |
| </template> |
| </ul> |
| <div class="controls"> |
| - <button id="add-website-language"> |
| + <button data-action="open-language-dialog"> |
| <span class="icon icon-add"></span> |
| <span class="i18n_options_language_add"></span> |
| </button> |
| @@ -113,7 +113,7 @@ |
| </ul> |
| </div> |
| <div class="controls"> |
| - <button id="add-blocking-list"> |
| + <button data-action="open-subscription-dialog"> |
| <span class="icon icon-add"></span> |
| <span class="i18n_options_furtherBlocking_add"><span> |
| </button> |
| @@ -149,16 +149,16 @@ |
| </ul> |
| <div class="controls"> |
| <div> |
| - <span id="whitelisting-add-icon" class="icon icon-add"></span> |
| + <span class="icon icon-add" data-action="add-domain-exception"></span> |
| <input type="text" id="whitelisting-textbox" /> |
| - <span id="whitelisting-enter-icon" class="icon icon-enter"></span> |
| + <span class="icon icon-enter" data-action="add-domain-exception"></span> |
| </div> |
| <div> |
| - <button id="whitelisting-add-button" class="button-add"> |
| + <button id="whitelisting-add-button" class="button-add" data-action="add-domain-exception"> |
| +<span class="i18n_options_button_add"></span> |
| </button> |
| <span></span> |
| - <button id="whitelisting-cancel-button" class="i18n_options_button_cancel cancel-button"></button> |
| + <button class="i18n_options_button_cancel cancel-button" data-action="cancel-domain-exception"></button> |
| </div> |
| </div> |
| </div> |
| @@ -261,11 +261,12 @@ |
| <span id="dialog-title"> |
| <span id="dialog-title-customlist" class="i18n_options_dialog_customlist_title"></span> |
| <span id="dialog-title-language" class="i18n_options_dialog_language_title"></span> |
| + <span id="dialog-title-addSubscription" class="i18n_options_dialog_addSubscription_title"></span> |
|
saroyanm
2015/07/13 16:20:07
I think make sense to have consistent IDs for each
Thomas Greiner
2015/07/13 18:37:14
Done but used different names to have shorter IDs.
|
| </span> |
| - <button id="dialog-close" class="i18n_options_close"></button> |
| + <button id="dialog-close" class="i18n_options_close" data-action="close-dialog"></button> |
| </header> |
| <div id="dialog-body" class="content"> |
| - <!-- Add other website language: Dialog --> |
| + <!-- Add other website language --> |
| <div id="dialog-content-language" class="dialog-content"> |
| <div class="dialog-content-block"> |
| <h3 class="i18n_options_dialog_language_added"></h3> |
| @@ -290,26 +291,37 @@ |
| </ul> |
| </div> |
| </div> |
| - <!-- Add other blocking list: Dialog --> |
| + <!-- Add other blocking list --> |
| <div id="dialog-content-customlist" class="dialog-content"> |
| <div class="dialog-content-block"> |
| <h3 class="i18n_options_dialog_customlist_subscription_title"></h3> |
| <div> |
| <input id="blockingList-textbox" type="text" placeholder="www.example.com/blockinglist.txt" /> |
| </div> |
| - <div id="import-blockingList-button" class="button-wrapper"> |
| + <div class="button-wrapper" data-action="import-subscription"> |
| <span class="icon icon-arrow"></span> |
| <span class="i18n_options_dialog_customlist_import"></span> |
| </div> |
| </div> |
| <div class="dialog-content-block"> |
| <h3 class="i18n_options_dialog_edit_own_list"></h3> |
| - <div id="edit-ownBlockingList-button" class="button-wrapper"> |
| + <div class="button-wrapper" data-action="edit-custom-filters"> |
| <span class="icon icon-arrow"></span> |
| <span class="i18n_options_dialog_create_own_list"></span> |
| </div> |
| </div> |
| </div> |
| + <!-- Add predefined subscription --> |
| + <div id="dialog-content-addSubscription" class="dialog-content"> |
|
saroyanm
2015/07/13 16:20:07
As mentioned above, make sense to name our dialogs
Thomas Greiner
2015/07/13 18:37:14
Done.
|
| + <div class="dialog-content-block"> |
| + <h3></h3> |
| + <div class="url"></div> |
| + <div class="button-wrapper" data-action="add-subscription"> |
| + <span class="icon icon-arrow"></span> |
| + <span class="i18n_options_dialog_addSubscription_confirm"></span> |
| + </div> |
| + </div> |
| + </div> |
| </div> |
| </div> |
| </body> |
« locale/en-US/options.json ('K')
|
« locale/en-US/options.json ('k')
|
options.js » ('j')
|
options.js » ('J')
