Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29321487: Issue 2738 - Fix tests to pass type bit mask to matching functions (Closed)

Created:
July 9, 2015, 1:46 p.m. by kzar
Modified:
July 14, 2015, 2:43 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 2738 - Fix tests to pass type bit mask to matching functions (Depends on the changes in this review https://codereview.adblockplus.org/29321478/ )

Patch Set 1 #

Patch Set 2 : Updated to match adblockplus changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/content/tests/matcher.js View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/content/tests/performance/matching.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/content/tests/regexpFilters_matching.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
kzar
July 9, 2015, 1:47 p.m. (2015-07-09 13:47:35 UTC) #1
Wladimir Palant
Looks good but will need changes given that we agreed on an API change in ...
July 10, 2015, 9:08 p.m. (2015-07-10 21:08:22 UTC) #2
kzar
Patch Set 2 : Updated to match adblockplus changes
July 12, 2015, 2:06 p.m. (2015-07-12 14:06:32 UTC) #3
Wladimir Palant
July 13, 2015, 6:59 p.m. (2015-07-13 18:59:45 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld