Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: popupBlocker.js

Issue 29321504: Issue 2738 - Pass bit masks to matching functions (Closed)
Patch Set: Created July 9, 2015, 2:50 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/whitelisting.js ('K') | « lib/whitelisting.js ('k') | webrequest.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: popupBlocker.js
diff --git a/popupBlocker.js b/popupBlocker.js
index 2735f0a987d5d6dbdd093efe9c5d51cfaaeb3be6..6fc5658afa72540a57de56073efac8bbdcbdc27c 100644
--- a/popupBlocker.js
+++ b/popupBlocker.js
@@ -56,7 +56,7 @@ function checkPotentialPopup(tabId, url, documentHost)
url = new URL(url || "about:blank");
var filter = defaultMatcher.matchesAny(
- stringifyURL(url), "POPUP",
+ stringifyURL(url), RegExpFilter.toTypeMask("POPUP"),
documentHost, isThirdParty(url, documentHost)
);
« lib/whitelisting.js ('K') | « lib/whitelisting.js ('k') | webrequest.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld