Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29322051: Issue 2766 - Remove underscores from DNS names (Closed)

Created:
July 13, 2015, 6:51 a.m. by mathias
Modified:
July 29, 2015, 11:31 a.m.
Reviewers:
Wladimir Palant
CC:
Felix Dahlke, Fred
Visibility:
Public.

Description

Issue 2766 - Remove underscores from DNS names

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M modules/private-stub/hiera/hosts.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M modules/statsmaster/manifests/awstats.pp View 1 chunk +1 line, -1 line 2 comments Download
M modules/web/templates/adblockplus.org.conf.erb View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
mathias
July 13, 2015, 6:51 a.m. (2015-07-13 06:51:50 UTC) #1
mathias
https://codereview.adblockplus.org/29322051/diff/29322052/modules/statsmaster/manifests/awstats.pp File modules/statsmaster/manifests/awstats.pp (right): https://codereview.adblockplus.org/29322051/diff/29322052/modules/statsmaster/manifests/awstats.pp#newcode130 modules/statsmaster/manifests/awstats.pp:130: host => 'server10.adblockplus.org', @trev Can you think of any ...
July 13, 2015, 6:53 a.m. (2015-07-13 06:53:44 UTC) #2
Wladimir Palant
July 13, 2015, 11:35 a.m. (2015-07-13 11:35:27 UTC) #3
LGTM

https://codereview.adblockplus.org/29322051/diff/29322052/modules/statsmaster...
File modules/statsmaster/manifests/awstats.pp (right):

https://codereview.adblockplus.org/29322051/diff/29322052/modules/statsmaster...
modules/statsmaster/manifests/awstats.pp:130: host =>
'server10.adblockplus.org',
On 2015/07/13 06:53:44, mathias wrote:
> @trev Can you think of any side-effects in the stats processing caused by this
> change? AFAIK it's fine as long as we don't touch the name ("intraforum.*") --

No, AWStats doesn't care about host names.

Powered by Google App Engine
This is Rietveld