Issue 2774 - Make the first run page work again

mobile/android/base/BrowserApp.java

 /* -*- Mode: Java; c-basic-offset: 4; tab-width: 4; indent-tabs-mode: nil; -*-
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 package org.mozilla.gecko;
 
 import org.mozilla.gecko.AppConstants.Versions;
 import org.mozilla.gecko.DynamicToolbar.PinReason;
 import org.mozilla.gecko.DynamicToolbar.VisibilityTransition;
@@ skipping 2434 matching lines @@
                 });
                 break;
             default:
                 super.onActivityResult(requestCode, resultCode, data);
         }
     }
 
     private void showFirstrunPager() {
         final DialogFragment dialog = new org.adblockplus.browser.StartPane();
         dialog.show(getSupportFragmentManager(), "start_pane");
-/* 

[Felix Dahlke, 2015/07/20 08:14:22]

Instead of commenting this out, we could do something like:

if (true)
    return;

Would be a bit more robust against upstream changes.

[René Jeschke, 2015/07/20 16:48:36]

Done.

-  Removed to revert to previous start pane behaviour, see https://issues.adblockplus.org/ticket/2774

[Felix Dahlke, 2015/07/20 08:14:22]

At this point this "start pane" is just ours - and I think we should rename it
at some point to how we're actually referring to it, "FirstRunFlow" or whatever.
So I'd just change the comment to say that we want to show our own first run
thing instead of Mozilla's here.

[René Jeschke, 2015/07/20 16:48:36]

Done.

+
+        // Exiting here because we want to show our first run page instead of Mozilla's
+        // see https://issues.adblockplus.org/ticket/2774
+        if (true)
+        {
+            return;
+        }
+
         if (mFirstrunPane == null) {
             final ViewStub firstrunPagerStub = (ViewStub) findViewById(R.id.firstrun_pager_stub);
             mFirstrunPane = (FirstrunPane) firstrunPagerStub.inflate();
             mFirstrunPane.load(getSupportFragmentManager());
             mFirstrunPane.registerOnFinishListener(new FirstrunPane.OnFinishListener() {
                 @Override
                 public void onFinish() {
                     BrowserApp.this.mFirstrunPane = null;
                 }
             });
         }
 
         mHomePagerContainer.setVisibility(View.VISIBLE);
-*/
     }
 
     private void showHomePager(String panelId) {
         showHomePagerWithAnimator(panelId, null);
     }
 
     private void showHomePagerWithAnimator(String panelId, PropertyAnimator animator) {
         if (isHomePagerVisible()) {
             // Home pager already visible, make sure it shows the correct panel.
             mHomePager.showPanel(panelId);
@@ skipping 1241 matching lines @@
                                          dispatcher,
                                          osLocale,
                                          appLocale,
                                          previousSession);
     }
 
     public static interface Refreshable {
         public void refresh();
     }
 }