Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Unified Diff: sitescripts/extensions/bin/createNightlies.py

Issue 29322523: Issue 2796 - Moved logic to extract Safari Developer ID to buildtools (Closed)
Patch Set: Removed obsolete import Created July 16, 2015, 3:46 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sitescripts/extensions/bin/updateUpdateManifests.py » ('j') | sitescripts/extensions/bin/updateUpdateManifests.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sitescripts/extensions/bin/createNightlies.py
===================================================================
--- a/sitescripts/extensions/bin/createNightlies.py
+++ b/sitescripts/extensions/bin/createNightlies.py
@@ -31,9 +31,7 @@
from urllib import urlencode
from xml.dom.minidom import parse as parseXml
from sitescripts.utils import get_config, setupStderr, get_template
-from sitescripts.extensions.utils import (
- compareVersions, Configuration, getSafariCertificateID,
- writeAndroidUpdateManifest)
+from sitescripts.extensions.utils import compareVersions, Configuration, writeAndroidUpdateManifest
Wladimir Palant 2015/07/16 20:47:08 This line is still too long - please break it into
Sebastian Noack 2015/07/17 11:10:59 Done.
MAX_BUILDS = 50
@@ -193,8 +191,9 @@
def readSafariMetadata(self):
import buildtools.packagerSafari as packager
metadata = packager.readMetadata(self.tempdir, self.config.type)
+ certs = packager.get_certificates_and_key(self.config.keyFile)[0]
- self.certificateID = getSafariCertificateID(self.config.keyFile)
+ self.certificateID = packager.get_developer_identifier(certs)
self.version = packager.getBuildVersion(self.tempdir, metadata, False, self.revision)
self.shortVersion = metadata.get("general", "version")
self.basename = metadata.get("general", "basename")
« no previous file with comments | « no previous file | sitescripts/extensions/bin/updateUpdateManifests.py » ('j') | sitescripts/extensions/bin/updateUpdateManifests.py » ('J')

Powered by Google App Engine
This is Rietveld