Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: sitescripts/extensions/bin/updateUpdateManifests.py

Issue 29322523: Issue 2796 - Moved logic to extract Safari Developer ID to buildtools (Closed)
Patch Set: Removed obsolete import Created July 16, 2015, 3:46 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sitescripts/extensions/bin/updateUpdateManifests.py
===================================================================
--- a/sitescripts/extensions/bin/updateUpdateManifests.py
+++ b/sitescripts/extensions/bin/updateUpdateManifests.py
@@ -25,11 +25,14 @@
import os
import re
import subprocess
+from ConfigParser import SafeConfigParser
+
from buildtools.packagerGecko import KNOWN_APPS
-from ConfigParser import SafeConfigParser
+from buildtools.packagerSafari import get_developer_identifier, get_certificates_and_key
Wladimir Palant 2015/07/16 20:47:08 Nit: This line is too long.
Sebastian Noack 2015/07/17 11:10:59 Done.
+
from sitescripts.utils import get_config, get_template
from sitescripts.extensions.utils import (
- Configuration, getDownloadLinks, getSafariCertificateID,
+ Configuration, getDownloadLinks,
writeIEUpdateManifest, writeAndroidUpdateManifest)
from sitescripts.extensions.android import get_min_sdk_version
@@ -52,7 +55,7 @@
elif repo.type == 'safari':
metadata = repo.readMetadata(version)
return {
- 'certificateID': getSafariCertificateID(repo.keyFile),
+ 'certificateID': get_developer_identifier(get_certificates_and_key(repo.keyFile)[0]),
Wladimir Palant 2015/07/16 20:47:08 Nit: This line is too long.
Sebastian Noack 2015/07/17 11:10:59 Done.
'version': version,
'shortVersion': version,
'basename': metadata.get('general', 'basename'),

Powered by Google App Engine
This is Rietveld