Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29322723: Issue 2805 - Only require filterValidation module where necessary (Closed)

Created:
July 20, 2015, 7:48 p.m. by Thomas Greiner
Modified:
July 21, 2015, 1:48 p.m.
Reviewers:
saroyanm
CC:
Sebastian Noack
Visibility:
Public.

Description

This is blocking the fix of #2710 which should be included in next weeks Firefox release. Therefore I opted for this fix instead of an implementation/abstraction of filterValidation in Firefox.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M messageResponder.js View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2
Thomas Greiner
July 20, 2015, 7:52 p.m. (2015-07-20 19:52:56 UTC) #1
saroyanm
July 21, 2015, 1:27 p.m. (2015-07-21 13:27:46 UTC) #2
On 2015/07/20 19:52:56, Thomas Greiner wrote:

LGTM as quick solution, 
IMO make sense to fix this in one of the upcoming new option page fixes.

Powered by Google App Engine
This is Rietveld