Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/css/index.css

Issue 29322769: Issue 2844 - Create Microsoft Edge coming soon landing page (Closed)
Left Patch Set: Do not use IDs in HTML, consider RTL and more comments addressing. Created Sept. 24, 2015, 2:30 a.m.
Right Patch Set: Use querySelectorAll instead of getElementsByClassName. Created Sept. 30, 2015, 7:56 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « pages/verification-success.html ('k') | static/css/index-desktop.css » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 #content h1, #content h2 1 #content h1, #content h2
2 { 2 {
3 font-size: 16px; 3 font-size: 16px;
4 } 4 }
5 5
6 #content .sprite 6 #content .sprite
7 { 7 {
8 background-image: url(../img/sprite-index.png); 8 background-image: url(../img/sprite-index.png);
9 } 9 }
10 10
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 { 73 {
74 background: #ffffff; 74 background: #ffffff;
75 padding: 10px; 75 padding: 10px;
76 border: 1px solid #c9c9c9; 76 border: 1px solid #c9c9c9;
77 box-shadow: 1px 1px 0 0 #dbdbdb; 77 box-shadow: 1px 1px 0 0 #dbdbdb;
78 } 78 }
79 79
80 #maxthon-instruction, 80 #maxthon-instruction,
81 html[lang^="zh_"] #content.maxthon #video, 81 html[lang^="zh_"] #content.maxthon #video,
82 #content.maxthon #feature-free, 82 #content.maxthon #feature-free,
83 #feature-maxthon, #edge-subscription, #edge-teaser 83 #feature-maxthon
84 { 84 {
85 display: none; 85 display: none;
86 } 86 }
87 87
88 html[lang^="zh_"] #content.maxthon #maxthon-instruction 88 html[lang^="zh_"] #content.maxthon #maxthon-instruction
89 { 89 {
90 display: inline-block; 90 display: inline-block;
91 padding: 0px; 91 padding: 0px;
92 } 92 }
93 93
94 #content.maxthon #feature-maxthon 94 #content.maxthon #feature-maxthon
95 { 95 {
96 display: inline-block; 96 display: inline-block;
97 }
98
99 #content.edge #video
100 {
101 display: none;
102 }
103
104 #content.edge #edge-subscription
105 {
106 display: block;
107 } 97 }
108 98
109 #summary h1, #summary h2 99 #summary h1, #summary h2
110 { 100 {
111 font-weight: normal; 101 font-weight: normal;
112 margin: 0; 102 margin: 0;
113 } 103 }
114 104
115 #summary h1 105 #summary h1
116 { 106 {
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
430 #platform-edge 420 #platform-edge
431 { 421 {
432 background-position: -68px -171px; 422 background-position: -68px -171px;
433 } 423 }
434 424
435 #content.edge #platform-edge 425 #content.edge #platform-edge
436 { 426 {
437 background-position: -68px -151px; 427 background-position: -68px -151px;
438 } 428 }
439 429
430 #content h3.subscribe-header
431 {
432 font-size: 18px;
433 margin-bottom: 0px;
434 }
435
436 #edge-subscription h3
437 {
438 margin: 19px 0px 10px 0px;
439 color: #2d79c0;
440 font-weight: bold;
441 font-family: Arial;
442 font-size: 14px;
443 }
444
445 #edge-subscription
446 {
447 margin: 0px 0px 10px 40px;
448 }
449
450 html[dir="rtl"] #edge-subscription
451 {
452 margin: 0px 40px 10px 0px;
453 }
454
455 #edge-subscription input[type=email]
456 {
457 border: solid 2px #a5a5a5;
458 padding: 0px 10px;
459 font-size: 14px;
460 font-family: Arial;
461 line-height: 36px;
462 height: 36px; /* IE 8 */
463 }
464
465 #edge-subscription input[type=email].placeholder
466 {
467 color: #a5a5a5;
468 }
469
470 #edge-subscription button[type=submit]
471 {
472 border: solid 1px #357ebd;
473 border-radius: 3px;
474 background-color: #428bca;
475 color: #ffffff;
476 font-size: 14px;
477 font-weight: bold;
478 width: 146px;
479 height: 40px;
480 }
481
482
483 #edge-subscription form > span, #edge-subscription form.success input,
484 #edge-subscription form.success button, #other-browsers, #content.edge #video,
485 #edge-subscription, #edge-teaser
486 {
487 display: none;
488 }
489
490 #edge-subscription form .invalid-label
491 {
492 margin-top: 15px;
493 }
494
495 #edge-subscription form.success .sucess-label,
496 #edge-subscription form.invalid .invalid-label,
497 #edge-subscription form.error .response-error,
498 #content.edge #edge-subscription
499 {
500 display: block;
501 }
502
440 .warning-platform, 503 .warning-platform,
441 .disclaimer, 504 .disclaimer,
442 #maxthon-notification 505 #maxthon-notification
443 { 506 {
444 display: none; 507 display: none;
445 color: #D00; 508 color: #D00;
446 text-align: center; 509 text-align: center;
447 border: 1px solid #D00; 510 border: 1px solid #D00;
448 padding: 5px; 511 padding: 5px;
449 border-radius: 5px; 512 border-radius: 5px;
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
639 #more-container.chrome #more-chrome, 702 #more-container.chrome #more-chrome,
640 #more-container.opera #more-opera, 703 #more-container.opera #more-opera,
641 #more-container.android #more-android, 704 #more-container.android #more-android,
642 #more-container.internet-explorer #more-internet-explorer, 705 #more-container.internet-explorer #more-internet-explorer,
643 #more-container.safari #more-safari, 706 #more-container.safari #more-safari,
644 #more-container.yandex-browser #more-yandex-browser, 707 #more-container.yandex-browser #more-yandex-browser,
645 #more-container.maxthon #more-maxthon 708 #more-container.maxthon #more-maxthon
646 #more-container.edge #more-edge 709 #more-container.edge #more-edge
647 { 710 {
648 background-color: #dbd4c7; 711 background-color: #dbd4c7;
649 } 712 }
650 #content h3.subscribe-header
saroyanm 2015/09/24 14:52:04 Detail: I think we can move rules that are related
651 {
652 font-size: 18px;
653 margin-bottom: 0px;
654 }
655
656 #edge-subscription h3
657 {
658 margin: 19px 0px 10px 0px;
659 color: #2d79c0;
660 font-weight: bold;
661 font-family: Arial;
662 font-size: 14px;
663 }
664
665 #edge-subscription
666 {
667 margin: 0px 0px 10px 40px;
668 }
669
670 html[dir="rtl"] #edge-subscription
671 {
672 margin: 0px 40px 10px 0px;
673 }
674
675 #edge-subscription input[type=email]
676 {
677 border: solid 2px #a5a5a5;
678 margin-right: 0px;
saroyanm 2015/09/24 14:52:04 Why do we need this rule ? I can't see any use for
679 padding: 0px 10px;
680 font-size: 14px;
681 font-family: Arial;
682 line-height: 36px;
683 height: 36px; /* IE 8 */
684 }
685
686 #edge-subscription input[type=email].placeholder
687 {
688 color: #a5a5a5;
689 }
690
691 #edge-subscription button[type=submit]
692 {
693 border: solid 1px #357EBD;
694 border-radius: 3px;
695 background-color: #428BCA;
saroyanm 2015/09/24 14:52:04 Detail: make sense to use consistent HEX numbers,
696 color: #FFFFFF;
697 font-size: 14px;
698 font-weight: bold;
699 width: 146px;
700 height: 40px;
701 margin-left: 0px;
saroyanm 2015/09/24 14:52:03 Same goes for this rule ? If there is no need to h
702 }
703
704
705 #edge-subscription form .sucess-label, #edge-subscription form .response-error,
706 #edge-subscription form .invalid-label, #edge-subscription form.success input,
707 #edge-subscription form.success button, #other-browsers
708 {
709 display: none;
710 }
711
712 #edge-subscription form .invalid-label
713 {
714 margin-top: 15px;
715 }
716
717 #edge-subscription form.success .sucess-label,
718 #edge-subscription form.invalid .invalid-label,
719 #edge-subscription form.error .response-error
720 {
721 display: block;
722 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld