Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(351)

Issue 29322846: Issue 2826 - Hamburger menu not visible on all pages (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 8 months ago by saroyanm
Modified:
4 years, 8 months ago
Reviewers:
Thomas Greiner
CC:
Felix Dahlke, kzar
Visibility:
Public.

Description

Issue 2826 - Hamburger menu not visible on all pages

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M static/css/main-mobile.css View 2 chunks +3 lines, -2 lines 0 comments Download
M static/js/main.js View 1 1 chunk +17 lines, -15 lines 0 comments Download
M templates/default.tmpl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
saroyanm
@Thomas can you please have a look. I've look through the Anwiki php code and ...
4 years, 8 months ago (2015-07-28 11:55:53 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29322846/diff/29322847/static/js/main.js File static/js/main.js (right): https://codereview.adblockplus.org/29322846/diff/29322847/static/js/main.js#newcode68 static/js/main.js:68: function navigationClick(e) Rename variable to "event" to (1) make ...
4 years, 8 months ago (2015-07-29 11:07:00 UTC) #2
saroyanm
https://codereview.adblockplus.org/29322846/diff/29322847/static/js/main.js File static/js/main.js (right): https://codereview.adblockplus.org/29322846/diff/29322847/static/js/main.js#newcode68 static/js/main.js:68: function navigationClick(e) On 2015/07/29 11:06:59, Thomas Greiner wrote: > ...
4 years, 8 months ago (2015-07-29 13:55:51 UTC) #3
Thomas Greiner
4 years, 8 months ago (2015-07-29 15:38:53 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5