Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(418)

Issue 29322888: Issue 2707 - Remove start/end from notifications (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by Felix Dahlke
Modified:
3 years, 10 months ago
Reviewers:
Sebastian Noack
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 2707 - Remove start/end from notifications

Patch Set 1 #

Total comments: 3

Patch Set 2 : Refactoring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M sitescripts/notifications/parser.py View 1 1 chunk +4 lines, -2 lines 0 comments Download
M sitescripts/notifications/test/parser.py View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Felix Dahlke
https://codereview.adblockplus.org/29322888/diff/29322889/sitescripts/notifications/parser.py File sitescripts/notifications/parser.py (right): https://codereview.adblockplus.org/29322888/diff/29322889/sitescripts/notifications/parser.py#newcode125 sitescripts/notifications/parser.py:125: if "start" in notification: Not entirely sure on how ...
3 years, 10 months ago (2015-07-29 10:45:11 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29322888/diff/29322889/sitescripts/notifications/parser.py File sitescripts/notifications/parser.py (right): https://codereview.adblockplus.org/29322888/diff/29322889/sitescripts/notifications/parser.py#newcode125 sitescripts/notifications/parser.py:125: if "start" in notification: On 2015/07/29 10:45:11, Felix Dahlke ...
3 years, 10 months ago (2015-07-29 11:28:54 UTC) #2
Felix Dahlke
https://codereview.adblockplus.org/29322888/diff/29322889/sitescripts/notifications/parser.py File sitescripts/notifications/parser.py (right): https://codereview.adblockplus.org/29322888/diff/29322889/sitescripts/notifications/parser.py#newcode125 sitescripts/notifications/parser.py:125: if "start" in notification: On 2015/07/29 11:28:54, Sebastian Noack ...
3 years, 10 months ago (2015-07-29 14:30:18 UTC) #3
Sebastian Noack
3 years, 10 months ago (2015-07-29 14:32:51 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5