Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29322919: Issue 2814 - Migrate filtermaster manifest + repository list to Hiera (Closed)

Created:
July 29, 2015, 12:05 p.m. by mathias
Modified:
July 29, 2015, 5:18 p.m.
Reviewers:
Felix Dahlke
CC:
Fred
Visibility:
Public.

Description

Issue 2814 - Migrate filtermaster manifest + repository list to Hiera

Patch Set 1 #

Patch Set 2 : Those exceptions... ;-) #

Patch Set 3 : Those typos... ;-) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M hiera/hosts.yaml View 1 chunk +1 line, -0 lines 0 comments Download
A hiera/roles/filtermasterserver.yaml View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5
mathias
July 29, 2015, 12:05 p.m. (2015-07-29 12:05:30 UTC) #1
Felix Dahlke
LGTM for this, but note my comment in https://codereview.adblockplus.org/29322760/diff/29322905
July 29, 2015, 1:52 p.m. (2015-07-29 13:52:11 UTC) #2
mathias
Those exceptions... ;-)
July 29, 2015, 3:16 p.m. (2015-07-29 15:16:52 UTC) #3
mathias
Those typos... ;-)
July 29, 2015, 3:19 p.m. (2015-07-29 15:19:16 UTC) #4
Felix Dahlke
July 29, 2015, 5:18 p.m. (2015-07-29 17:18:13 UTC) #5
Message was sent while issue was closed.
LGTM. Fun fact: I was actually considering to complain about "alias" in the
other review, because it's not really making it clear what this is. It's more
like "config_key" or something. But it didn't seem too important, I'd rather
prefer to ensure config key and repo always have the same name.

Powered by Google App Engine
This is Rietveld