Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: options.html

Issue 29322998: Issue 2669 - Use header, footer and nav tags in options page sidebar (Closed)
Patch Set: Created July 29, 2015, 4:49 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: options.html
===================================================================
--- a/options.html
+++ b/options.html
@@ -31,38 +31,42 @@
<!-- Navigation sidebar -->
<div id="nav-sidebar">
<div id="fixed-sidebar" class="fixed">
- <div id="page-title">
+ <header id="page-title">
<p class="i18n_options_page_header_1"></p>
<h1 class="i18n_options_page_header_2"></h1>
- </div>
- <ul class="tabs vertical">
- <li id="tab-general" data-action="switch-tab" data-tab="general" class="active">
- <a class="i18n_options_tab_general"></a>
- <span class="icon"></span>
- </li>
- <li id="tab-advanced" data-action="switch-tab" data-tab="advanced">
- <a class="i18n_options_tab_advanced"></a>
- <span class="icon"></span>
- </li>
- <li id="tab-help" data-action="switch-tab" data-tab="help">
- <a class="i18n_options_tab_help"></a>
- <span class="icon"></span>
- </li>
- </ul>
+ </header>
+ <nav>
+ <ul class="tabs vertical">
+ <li id="tab-general" data-action="switch-tab" data-tab="general" class="active">
+ <a class="i18n_options_tab_general"></a>
+ <span class="icon"></span>
+ </li>
+ <li id="tab-advanced" data-action="switch-tab" data-tab="advanced">
+ <a class="i18n_options_tab_advanced"></a>
+ <span class="icon"></span>
+ </li>
+ <li id="tab-help" data-action="switch-tab" data-tab="help">
+ <a class="i18n_options_tab_help"></a>
+ <span class="icon"></span>
+ </li>
+ </ul>
+ </nav>
<a id="link-version">
<span class="i18n_options_version"></span>
<span id="abp-version"></span>
</a>
- <ul class="tabs vertical bottom">
- <li id="tab-share">
- <a class="i18n_options_tab_share"></a>
- <span class="icon"></span>
- </li>
- <li id="tab-contribute">
- <a class="i18n_options_tab_contribute"></a>
- <span class="icon"></span>
- </li>
- </ul>
+ <footer>
+ <ul class="tabs vertical bottom">
+ <li id="tab-share">
+ <a class="i18n_options_tab_share"></a>
+ <span class="icon"></span>
+ </li>
+ <li id="tab-contribute">
+ <a class="i18n_options_tab_contribute"></a>
+ <span class="icon"></span>
+ </li>
+ </ul>
+ </footer>
</div>
</div>
<div id="tab-content">
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld