Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: options.html

Issue 29323156: Issue 2410 - Improved accessibility of dialogs in options page (Closed)
Left Patch Set: Created July 31, 2015, 3:02 p.m.
Right Patch Set: Created Oct. 2, 2015, 2:11 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | options.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-2015 Eyeo GmbH 4 - Copyright (C) 2006-2015 Eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
11 - but WITHOUT ANY WARRANTY; without even the implied warranty of 11 - but WITHOUT ANY WARRANTY; without even the implied warranty of
12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 12 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 - GNU General Public License for more details. 13 - GNU General Public License for more details.
14 - 14 -
15 - You should have received a copy of the GNU General Public License 15 - You should have received a copy of the GNU General Public License
16 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 16 - along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
17 --> 17 -->
18 18
19 <html> 19 <html>
20 <head> 20 <head>
21 <meta charset="utf-8"> 21 <meta charset="utf-8">
22 <title class="i18n_options_page_title"></title> 22 <title class="i18n_options_page_title"></title>
23 <link rel="stylesheet" href="skin/common.css">
23 <link rel="stylesheet" href="skin/options.css"> 24 <link rel="stylesheet" href="skin/options.css">
24 <style id="search-style"></style> 25 <style id="search-style"></style>
25 <script src="ext/common.js"></script> 26 <script src="ext/common.js"></script>
26 <script src="ext/content.js"></script> 27 <script src="ext/content.js"></script>
28 <script src="common.js"></script>
27 <script src="i18n.js"></script> 29 <script src="i18n.js"></script>
28 <script src="options.js"></script> 30 <script src="options.js"></script>
29 </head> 31 </head>
30 <body data-tab="general"> 32 <body data-tab="general">
31 <!-- Navigation sidebar --> 33 <!-- Navigation sidebar -->
32 <div id="nav-sidebar"> 34 <div id="nav-sidebar">
33 <div id="fixed-sidebar" class="fixed"> 35 <div id="fixed-sidebar" class="fixed">
34 <header id="page-title"> 36 <header id="page-title">
35 <p class="i18n_options_page_header_1"></p> 37 <p class="i18n_options_page_header_1"></p>
36 <h1 class="i18n_options_page_header_2"></h1> 38 <h1 class="i18n_options_page_header_2"></h1>
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 <h3 class="i18n_options_dialog_language_added"></h3> 316 <h3 class="i18n_options_dialog_language_added"></h3>
315 <ul id="blocking-languages-dialog-table" class="table list"> 317 <ul id="blocking-languages-dialog-table" class="table list">
316 <template> 318 <template>
317 <span class="display"></span> 319 <span class="display"></span>
318 </template> 320 </template>
319 </ul> 321 </ul>
320 </div> 322 </div>
321 <div id="other-language" class="dialog-content-block"> 323 <div id="other-language" class="dialog-content-block">
322 <div> 324 <div>
323 <label for="find-language" class="i18n_options_dialog_language_oth er"></label> 325 <label for="find-language" class="i18n_options_dialog_language_oth er"></label>
324 <input type="search" id="find-language" class="default-action" /> 326 <input type="search" id="find-language" class="default-focus" />
325 </div> 327 </div>
326 <ul id="all-lang-table" class="table list"> 328 <ul id="all-lang-table" class="table list">
327 <template> 329 <template>
328 <button class="button-add control"> 330 <button class="button-add control">
329 +<span></span> 331 +<span></span>
330 </button> 332 </button>
331 <span class="display"></span> 333 <span class="display"></span>
332 </template> 334 </template>
333 </ul> 335 </ul>
334 </div> 336 </div>
335 </div> 337 </div>
336 <!-- Add custom subscription --> 338 <!-- Add custom subscription -->
337 <div id="dialog-content-custom" class="dialog-content"> 339 <div id="dialog-content-custom" class="dialog-content">
338 <div class="dialog-content-block"> 340 <div class="dialog-content-block">
339 <div> 341 <div>
340 <label for="blockingList-textbox" class="i18n_options_dialog_custo m_subscription_title"></label> 342 <label for="blockingList-textbox" class="i18n_options_dialog_custo m_subscription_title"></label>
341 <input id="blockingList-textbox" type="text" class="default-action " placeholder="www.example.com/blockinglist.txt" /> 343 <input id="blockingList-textbox" type="text" class="default-focus" placeholder="www.example.com/blockinglist.txt" />
342 </div> 344 </div>
343 <button class="i18n_options_dialog_custom_import" data-action="impor t-subscription"></button> 345 <button class="i18n_options_dialog_custom_import" data-action="impor t-subscription"></button>
344 </div> 346 </div>
345 <div class="dialog-content-block"> 347 <div class="dialog-content-block">
346 <h3 class="i18n_options_dialog_edit_own_list"></h3> 348 <h3 class="i18n_options_dialog_edit_own_list"></h3>
347 <button class="i18n_options_dialog_create_own_list" data-action="clo se-dialog,switch-tab,edit-custom-filters" data-tab="advanced"></button> 349 <button class="i18n_options_dialog_create_own_list" data-action="clo se-dialog,switch-tab,edit-custom-filters" data-tab="advanced"></button>
348 </div> 350 </div>
349 </div> 351 </div>
350 <!-- Add predefined subscription --> 352 <!-- Add predefined subscription -->
351 <div id="dialog-content-predefined" class="dialog-content"> 353 <div id="dialog-content-predefined" class="dialog-content">
352 <div class="dialog-content-block"> 354 <div class="dialog-content-block">
353 <h3></h3> 355 <h3></h3>
354 <div class="url"></div> 356 <div class="url"></div>
355 <button class="i18n_options_dialog_predefined_confirm default-action " data-action="add-predefined-subscription"></button> 357 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button>
356 </div> 358 </div>
357 </div> 359 </div>
358 </div> 360 </div>
359 <!-- Placeholder element to determine when to wrap focus around --> 361 <!-- Placeholder element to determine when to wrap focus around -->
360 <span class="focus-last" tabindex="0"></span> 362 <span class="focus-last" tabindex="0"></span>
361 </div> 363 </div>
362 </body> 364 </body>
363 </html> 365 </html>
LEFTRIGHT
« no previous file | options.js » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld