Issue 2410 - Improved accessibility of dialogs in options page

options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 479 matching lines @@
       {
         case "Escape":
           closeDialog();
           break;
         case "Tab":
           if (e.shiftKey)
           {
             if (e.target.classList.contains("focus-first"))
             {
               e.preventDefault();
-              document.querySelector("#dialog .focus-last").focus();
+              this.querySelector(".focus-last").focus();
             }
           }
           else if (e.target.classList.contains("focus-last"))
           {
             e.preventDefault();
-            document.querySelector("#dialog .focus-first").focus();
+            this.querySelector(".focus-first").focus();
           }
           break;
       }
     }, false);
   }
 
   var focusedBeforeDialog = null;
   function openDialog(name)
   {
     var dialog = E("dialog");
     dialog.setAttribute("aria-hidden", false);
     dialog.setAttribute("aria-labelledby", "dialog-title-" + name);
     document.body.setAttribute("data-dialog", name);
 
-    var defaultAction = document.querySelector("#dialog-content-" + name
-      + " .default-action");
-    if (!defaultAction)
-      defaultAction = document.querySelector("#dialog .focus-first");
+    var defaultFocus = document.querySelector("#dialog-content-" + name
+      + " .default-focus");
+    if (!defaultFocus)
+      defaultFocus = dialog.querySelector(".focus-first");
     focusedBeforeDialog = document.activeElement;
-    defaultAction.focus();
+    defaultFocus.focus();
   }
 
   function closeDialog()
   {
     var dialog = E("dialog");
     dialog.setAttribute("aria-hidden", true);
     dialog.removeAttribute("aria-labelledby");
     document.body.removeAttribute("data-dialog");
     focusedBeforeDialog.focus();
   }
@@ skipping 169 matching lines @@
           }
           updateShareLink();
         });
         break;
       case "title":
         // TODO: NYI
         break;
     }
   }
 
+  function onShareLinkClick(e)
+  {
+    e.preventDefault();
+
+    getDocLink("share-general", function(link)
+    {
+      openSharePopup(link);
+    });
+  }
+
   function updateShareLink()
   {
-    ext.backgroundPage.sendMessage(
-    {
-      type: "filters.blocked",
-      url: "https://platform.twitter.com/widgets/",
-      requestType: "SCRIPT",
-      docDomain: "adblockplus.org",
-      thirdParty: true
-    },
-    function(blocked)
-    {
-      // TODO: modify "share" link accordingly
-    });
-  }
-
-  function E(id)
-  {
-    return document.getElementById(id);
-  }
-
-  function getDocLink(link, callback)
-  {
-    ext.backgroundPage.sendMessage(
-    {
-      type: "app.get",
-      what: "doclink",
-      link: link
-    }, callback);
+    var shareResources = [
+      "https://facebook.com/plugins/like.php?",
+      "https://platform.twitter.com/widgets/",
+      "https://apis.google.com/se/0/_/+1/fastbutton?"
+    ];
+    var isAnyBlocked = false;
+    var checksRemaining = shareResources.length;
+
+    function onResult(isBlocked)
+    {
+      isAnyBlocked |= isBlocked;
+      if (!--checksRemaining)
+      {
+        // Hide the share tab if a script on the share page would be blocked
+        var tab = E("tab-share");
+        if (isAnyBlocked)
+        {
+          tab.hidden = true;
+          tab.removeEventListener("click", onShareLinkClick, false);
+        }
+        else
+          tab.addEventListener("click", onShareLinkClick, false);
+      }
+    }
+
+    for (var i = 0; i < shareResources.length; i++)
+      checkShareResource(shareResources[i], onResult);
   }
 
   ext.onMessage.addListener(function(message)
   {
     switch (message.type)
     {
       case "app.listen":
         if (message.action == "addSubscription")
         {
           var subscription = message.args[0];
@@ skipping 27 matching lines @@
     filter: ["added", "loaded", "removed"]
   });
   ext.backgroundPage.sendMessage(
   {
     type: "subscriptions.listen",
     filter: ["added", "disabled", "homepage", "removed", "title"]
   });
 
   window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
 })();