Issue 2410 - Improved accessibility of dialogs in options page

skin/options.css

Index: skin/options.css
===================================================================
--- a/skin/options.css
+++ b/skin/options.css
@@ -479,7 +479,8 @@
 
 .icon, .table input[type="checkbox"]::before, .table button.delete,
 #content-help a::before, #dialog-close::before,
-#custom-filters-add button::after
+#custom-filters-add button::after,
+#dialog-body button::before

[saroyanm, 2015/10/01 16:31:40]

Nit: should not exceed the 80 char limit if you put inline with the line before.

[saroyanm, 2015/10/01 17:27:04]

Just noticed that the consistency in either case is missing for selectors, feel
free to ignore my comments regarding that.

 {
   background-image: url(options-sprite.png);
   display: inline-block;
@@ -509,8 +510,8 @@
   width: 18px;
 }
 
-.icon-arrow,
-#content-help a::before
+#content-help a::before,
+#dialog-body button::before

[saroyanm, 2015/10/01 16:31:41]

Nit: should not exceed the 80 char limit if you put inline with the line before.

[Thomas Greiner, 2015/10/02 10:27:29]

Sure but it's more readable if each selector is on its own line, don't you think
so?

[saroyanm, 2015/10/02 13:18:50]

I agree with you, from readability point of view having every selector on it's
own line make more sense, but it makes file also bigger, so I will vote for
current approach if we are okey having bigger files.

[Thomas Greiner, 2015/10/02 14:17:32]

Bigger files should not be an issue as long as the code inside is well
structured and easily understandable.

 {
   background-position: 0px -42px;
   content: "";
@@ -518,6 +519,8 @@
   height: 11px;
   vertical-align: middle;
   width: 7px;
+  -moz-margin-end: 12px;

[saroyanm, 2015/10/01 16:31:40]

Just as remark: I think from some point we should also use standardized version
as well:
margin-inline-end (same for other similar elements).

[Thomas Greiner, 2015/10/02 10:27:29]

Unfortunately, there's no standardized version yet. All there is right now is a
draft so at this point it's not stable enough to rely on a non-prefixed version.

[saroyanm, 2015/10/02 13:18:50]

I see, make sense also not use border-inline-start-width in first run page, I
think we used that property there, that why I thought it standardized. 

[Thomas Greiner, 2015/10/02 14:17:32]

I guess we can tackle that whenever we make changes to firstRun.css

+  -webkit-margin-end: 12px;
 }
 
 .controls
@@ -1000,9 +1003,11 @@
   margin: 4px 24px;
 }
 
-#dialog h3
+#dialog h3,
+#dialog label

[saroyanm, 2015/10/01 16:31:40]

Nit: should not exceed the 80 char limit if you put inline with the line before.

 {
   font-size: 14px;
+  font-weight: 600;
   margin: 0px;
 }
 
@@ -1045,22 +1050,18 @@
   padding: 12px 0px;
 }
 
-#dialog .button-wrapper
+#dialog-body button
 {
   background-color: #F5F5F5;
+  border: none;
+  color: #3A7BA6;
+  cursor: pointer;
+  display: block;
+  font-family: inherit;
   margin-top: 8px;
   padding: 10px 16px;
-  cursor: pointer;
-  width: auto;
-}
-
-#dialog .button-wrapper span:not(.icon)
-{
-  color: #3A7BA6;
-  display: inline-block;
-  -moz-margin-start: 15px;
-  -webkit-margin-start: 15px;
-  vertical-align: top;
+  text-align: left;

[saroyanm, 2015/10/01 16:31:40]

Please also consider the case for RTL.

[Thomas Greiner, 2015/10/02 10:27:29]

Done.

+  width: 100%;
 }
 
 #dialog .url
@@ -1083,6 +1084,10 @@
 
 #other-language .button-add
 {
+  background-color: transparent;
+  margin: 0px;
+  padding: 0px;
+  width: auto;
   -webkit-border-end: 1px solid #CDCDCD;
   -moz-border-end: 1px solid #CDCDCD;
   -webkit-padding-end: 10px;
@@ -1091,6 +1096,11 @@
   -moz-padding-start: 0px;
 }
 
+#other-language .button-add::before
+{
+  display: none;
+}
+
 #other-language .display
 {
   -webkit-margin-start: 10px;