Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(431)

Issue 29323423: Issue 2869 - Setup cron-job to update notifications (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by mathias
Modified:
4 years, 6 months ago
Reviewers:
Felix Dahlke, Fred
Visibility:
Public.

Description

Aligned with Cron[update_sitescripts], but every 5 minutes only.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Issue 2869 - Fix requirement declaration for Cron[update_notifications] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M modules/notificationserver/manifests/init.pp View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6
mathias
4 years, 6 months ago (2015-08-10 11:13:28 UTC) #1
Fred
https://codereview.adblockplus.org/29323423/diff/29323424/modules/notificationserver/manifests/init.pp File modules/notificationserver/manifests/init.pp (right): https://codereview.adblockplus.org/29323423/diff/29323424/modules/notificationserver/manifests/init.pp#newcode29 modules/notificationserver/manifests/init.pp:29: require => Exec["fetch_sitescripts"], I guess you meant require => ...
4 years, 6 months ago (2015-08-10 11:46:46 UTC) #2
mathias
4 years, 6 months ago (2015-08-10 11:59:05 UTC) #3
mathias
https://codereview.adblockplus.org/29323423/diff/29323424/modules/notificationserver/manifests/init.pp File modules/notificationserver/manifests/init.pp (right): https://codereview.adblockplus.org/29323423/diff/29323424/modules/notificationserver/manifests/init.pp#newcode29 modules/notificationserver/manifests/init.pp:29: require => Exec["fetch_sitescripts"], On 2015/08/10 11:46:46, Fred wrote: > ...
4 years, 6 months ago (2015-08-10 12:00:02 UTC) #4
Felix Dahlke
LGTM
4 years, 6 months ago (2015-08-10 13:09:14 UTC) #5
Fred
4 years, 6 months ago (2015-08-10 13:11:40 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5