Issue 2869 - Setup cron-job to update notifications

modules/notificationserver/manifests/init.pp

 class notificationserver($is_default = false) {
   if !defined(Class['nginx']) {
     class {'nginx':
       worker_processes => 2,
       worker_connections => 4000,
       ssl_session_cache => off,
     }
   }
 
   class {'sitescripts':
     sitescriptsini_source => 'puppet:///modules/notificationserver/sitescripts.ini'
   }
 
   exec {'fetch_notifications':
     command => 'hg clone --noupdate https://hg.adblockplus.org/notifications /opt/notifications && chown -R nginx /opt/notifications',
     path => ['/usr/bin/', '/bin/'],
     require => [
       Package['mercurial'],
       Package['nginx'],
     ],
     onlyif => 'test ! -d /opt/notifications'
   }
 
   cron {'update_notifications':
     command => 'hg pull -q -u -R /opt/notifications',
     environment => ['MAILTO=admins@adblockplus.org,root'],
     minute => '*/5',
     user => 'nginx',
-    require => Exec["fetch_sitescripts"],

[Fred, 2015/08/10 11:46:46]

I guess you meant
require => Exec["fetch_notifications"]
here?

[mathias, 2015/08/10 12:00:02]

Thank you! Classic copy+paste issue that worked because of lucky ordering.
Didn't we just discuss such examples last week? ;-)

+    require => Exec['fetch_notifications'],
   }
 
   include spawn-fcgi
   package {'python-flup':}
 
   spawn-fcgi::pool {'multiplexer':
     ensure => present,
     fcgi_app => '/opt/sitescripts/multiplexer.fcgi',
     socket => '/tmp/multiplexer-fastcgi.sock',
     mode => '0666',
@@ skipping 15 matching lines @@
   nginx::hostconfig{'notification.adblockplus.org':
     source => 'puppet:///modules/notificationserver/site.conf',
     global_config => template('notificationserver/global.conf.erb'),
     is_default => $is_default,
     certificate => 'easylist-downloads.adblockplus.org_sslcert.pem',
     private_key => 'easylist-downloads.adblockplus.org_sslcert.key',
     log => 'access_log_notification',
     log_format => 'notification',
   }
 }