Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(769)

Issue 29323439: Issue 2877 - Element Hiding Helper causes tab to crash when selecting some elements (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by Wladimir Palant
Modified:
4 years, 10 months ago
Reviewers:
saroyanm
Visibility:
Public.

Description

Issue 2877 - Element Hiding Helper causes tab to crash when selecting some elements

Patch Set 1 #

Total comments: 5

Patch Set 2 : Removed extra newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -13 lines) Patch
M chrome/content/frameScript.js View 1 chunk +2 lines, -1 line 0 comments Download
M lib/aardvark.js View 1 2 chunks +28 lines, -12 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
4 years, 10 months ago (2015-08-10 21:22:25 UTC) #1
saroyanm
https://codereview.adblockplus.org/29323439/diff/29323440/chrome/content/frameScript.js File chrome/content/frameScript.js (right): https://codereview.adblockplus.org/29323439/diff/29323440/chrome/content/frameScript.js#newcode1 chrome/content/frameScript.js:1: /* Did this file exist ? I can't find ...
4 years, 10 months ago (2015-08-11 08:41:50 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29323439/diff/29323440/chrome/content/frameScript.js File chrome/content/frameScript.js (right): https://codereview.adblockplus.org/29323439/diff/29323440/chrome/content/frameScript.js#newcode1 chrome/content/frameScript.js:1: /* On 2015/08/11 08:41:50, saroyanm wrote: > Did this ...
4 years, 10 months ago (2015-08-11 10:05:18 UTC) #3
saroyanm
LGTM with small nit. https://codereview.adblockplus.org/29323439/diff/29323440/chrome/content/frameScript.js File chrome/content/frameScript.js (right): https://codereview.adblockplus.org/29323439/diff/29323440/chrome/content/frameScript.js#newcode1 chrome/content/frameScript.js:1: /* On 2015/08/11 10:05:18, Wladimir ...
4 years, 10 months ago (2015-08-11 13:50:15 UTC) #4
Wladimir Palant
4 years, 10 months ago (2015-08-11 13:57:06 UTC) #5
https://codereview.adblockplus.org/29323439/diff/29323440/lib/aardvark.js
File lib/aardvark.js (right):

https://codereview.adblockplus.org/29323439/diff/29323440/lib/aardvark.js#new...
lib/aardvark.js:615: 
On 2015/08/11 13:50:14, saroyanm wrote:
> Nit: please remove new line here.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5