Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/typedObjects.js

Issue 29323484: Issue 507 - Implement lightweight array.slice() method (Closed)
Patch Set: Small improvements Created Aug. 19, 2015, 12:14 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/typedObjects/arrayTypes.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/typedObjects.js
diff --git a/lib/typedObjects.js b/lib/typedObjects.js
index 690c5b5723ba33691a5387768355dfe745ff45e2..e789d89cd5d2682ad992e48b5cc55fd1d8eb5624 100644
--- a/lib/typedObjects.js
+++ b/lib/typedObjects.js
@@ -155,13 +155,13 @@
* equal to length. Normally you won't need to set the size explicitly.
* However, the size won't decrease automatically if the array gets
* smaller so you might want to set it in order to shrink the array.
- * splice(), push(), pop(), unshift(), shift(): these work the same as the
- * corresponding methods on JavaScript's Array class. Note however that
- * using pop() and shift() with arrays of objects is dangerous if you
- * want to work with their return value: this operation will call
- * release() on the resulting object before returning which might result
- * in it being garbage collected. You should call retain() on the array
- * element before calling pop() or shift().
+ * slice(), splice(), push(), pop(), unshift(), shift(): these work the
+ * same as the corresponding methods on JavaScript's Array class.
+ * Note however that using pop() and shift() with arrays of objects is
+ * dangerous if you want to work with their return value: this operation
+ * will call release() on the resulting object before returning which
+ * might result in it being garbage collected. You should call retain()
+ * on the array element before calling pop() or shift().
*
* String type
* -----------
« no previous file with comments | « no previous file | lib/typedObjects/arrayTypes.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld