src/plugin/PluginClass.h - Issue 29323561: Issue #3383 - Rewrite and simplify browser-site handling in CPluginClass

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/plugin/PluginClass.h

Issue 29323561: Issue #3383 - Rewrite and simplify browser-site handling in CPluginClass (Closed)

Left Patch Set: address comments Created Nov. 30, 2015, 4:30 p.m.

Right Patch Set: initialization; shorten comment Created Dec. 3, 2015, 2:23 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-2015 Eyeo GmbH	3 * Copyright (C) 2006-2015 Eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 121 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
132 void STDMETHODCALLTYPE OnDocumentComplete(IDispatch* frameBrowserDisp, VARIANT * /urlOrPidl/);	132 void STDMETHODCALLTYPE OnDocumentComplete(IDispatch* frameBrowserDisp, VARIANT * /urlOrPidl/);

133 void STDMETHODCALLTYPE OnWindowStateChanged(unsigned long flags, unsigned long validFlagsMask);	133 void STDMETHODCALLTYPE OnWindowStateChanged(unsigned long flags, unsigned long validFlagsMask);

134 void STDMETHODCALLTYPE OnCommandStateChange(long command, VARIANT_BOOL enable) ;	134 void STDMETHODCALLTYPE OnCommandStateChange(long command, VARIANT_BOOL enable) ;

135 void STDMETHODCALLTYPE OnOnQuit();	135 void STDMETHODCALLTYPE OnOnQuit();

136 void Unadvise();	136 void Unadvise();

137	137

138 void ShowStatusBar();	138 void ShowStatusBar();

139 bool IsStatusBarEnabled();	139 bool IsStatusBarEnabled();

140	140

141 /**	141 /**

142 * Our site object as a browser.	142 * A browser interface pointer to our site object

143 *	143 *

144 * It's values are set and reset solely in SetSite().	144 * It's values are set and reset solely in SetSite().

145 * The declaration as CComPtr is defensive programming;

146 * it ensures that the site keeps this interface alive for us in the

147 * unlikely case that the site is different from a browser.

148 */	145 */

149 CComPtr<IWebBrowser2> m_webBrowser2;	146 CComPtr<IWebBrowser2> m_webBrowser2;

150 HWND m_hBrowserWnd;	147 HWND m_hBrowserWnd;

151 HWND m_hTabWnd;	148 HWND m_hTabWnd;

152 HWND m_hStatusBarWnd;	149 HWND m_hStatusBarWnd;

153 HWND m_hPaneWnd;	150 HWND m_hPaneWnd;

154	151

155 WNDPROC m_pWndProcStatus;	152 WNDPROC m_pWndProcStatus;

156 int m_nPaneWidth;	153 int m_nPaneWidth;

157 HANDLE m_hTheme;	154 HANDLE m_hTheme;

(...skipping 28 matching lines...) Expand all Loading...
186	183

187 // Async browser	184 // Async browser

188 static CComQIPtr<IWebBrowser2> s_asyncWebBrowser2;	185 static CComQIPtr<IWebBrowser2> s_asyncWebBrowser2;

189 static CComQIPtr<IWebBrowser2> GetAsyncBrowser();	186 static CComQIPtr<IWebBrowser2> GetAsyncBrowser();

190 };	187 };

191	188

192 OBJECT_ENTRY_AUTO(__uuidof(PluginClass), CPluginClass)	189 OBJECT_ENTRY_AUTO(__uuidof(PluginClass), CPluginClass)

193	190

194	191

195 #endif // _PLUGIN_CLASS_H_	192 #endif // _PLUGIN_CLASS_H_

LEFT	RIGHT