Issue #1234, #2058 - Rewrite log facility, improving thread implementation

src/plugin/PluginSettings.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 53 matching lines @@
     }
 
     instance = s_instance;
   }
   s_criticalSectionLocal.Unlock();
 
   return instance;
 }
 
 
-bool CPluginSettings::HasInstance()
-{
-  bool hasInstance = true;
-
-  s_criticalSectionLocal.Lock();
-  {
-    hasInstance = s_instance != NULL;
-  }
-  s_criticalSectionLocal.Unlock();
-
-  return hasInstance;
-}
-
 bool CPluginSettings::IsPluginEnabled() const
 {
   return GetPluginEnabled();
 }
 
 std::map<std::wstring, std::wstring> CPluginSettings::GetFilterLanguageTitleList() const
 {
   auto subscriptions = CPluginClient::GetInstance()->FetchAvailableSubscriptions();
 
   std::map<std::wstring, std::wstring> filterList;
   for (size_t i = 0; i < subscriptions.size(); i ++)
   {
     auto it = subscriptions[i];
     filterList.insert(std::make_pair(it.url, it.title));
   }
   return filterList;
 }
 
 void CPluginSettings::TogglePluginEnabled()
 {
   CPluginClient::GetInstance()->TogglePluginEnabled();  
 }
 bool CPluginSettings::GetPluginEnabled() const
 {
   return CPluginClient::GetInstance()->GetPref(L"enabled", true);
 }
 
-void CPluginSettings::AddError(const CString& error, const CString& errorCode)
-{
-  DEBUG_SETTINGS(L"SettingsTab::AddError error:" + error + " code:" + errorCode)
-}
-
 // ============================================================================
 // Whitelist settings
 // ============================================================================
 
 void CPluginSettings::ClearWhitelist()
 {
   s_criticalSectionLocal.Lock();
   {
     m_whitelistedDomains.clear();
   }
@@ skipping 84 matching lines @@
 
   for (auto subscription = subscriptions.begin(); subscription != subscriptions.end(); subscription++)
   {
     if (subscription->url != aaUrl)
     {
       return subscription->url;
     }
   }
   return std::wstring();
 }