Issue #1234, #2058 - Rewrite log facility, improving thread implementation

src/plugin/PluginDebug.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2015 Eyeo GmbH
+ * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
@@ skipping 44 matching lines @@
 
   CComAutoCriticalSection CPluginDebugLock::s_criticalSectionDebugLock;
 
   /**
    * The polymorphic part of a log entry.
    */
   class LogText
   {
   public:
     virtual std::string Text() const = 0;
+    virtual ~LogText() {};
   };
 
   class LogTextFixed
     : public LogText
   {
   protected:
     const std::string fixedText;
 
   public:
     explicit LogTextFixed(const std::string& text)
@@ skipping 384 matching lines @@
 
 void Trace::ErrorCode(DWORD errorCode, const std::string& description, Trace::Location location)
 {
   LogQueue::Insert(LogEntry(new LogTextErrorCode(errorCode, description), location));
 }
 
 void Trace::TextFixed(const std::string& description, Trace::Location location)
 {
   LogQueue::Insert(LogEntry(new LogTextFixed(description), location));
 }
+
+namespace
+{
+  /*
+   * To convert a pointer to a hexadecimal number, we need an integral type that has the same size as that of the pointer.
+   */
+#if defined(_WIN64)
+  typedef uint64_t voidIntegral;
+  static_assert(sizeof(void*)==sizeof(voidIntegral),"WIN64: sizeof(uint64_t) is not the same as sizeof(void*)");
+#elif defined(_WIN32)
+  typedef uint32_t voidIntegral;
+  static_assert(sizeof(void*)==sizeof(voidIntegral),"WIN32: sizeof(uint32_t) is not the same as sizeof(void*)");
+#else
+#error Must compile with either _WIN32 or _WIN64
+#endif
+}
+
+std::wstring ToHexLiteral(void const* p)
+{
+  std::wstringstream ss;
+  ss << L"0x";
+  ss.width(sizeof(p) * 2);
+  ss.fill(L'0');
+  ss << std::hex << reinterpret_cast<voidIntegral>(p);
+  return ss.str();
+}