Issue #1234, #2058 - Rewrite log facility, improving thread implementation

adblockplus.gyp

Index: adblockplus.gyp
===================================================================
--- a/adblockplus.gyp
+++ b/adblockplus.gyp
@@ -111,6 +111,7 @@
       'libadblockplus/libadblockplus.gyp:libadblockplus',
     ],
     'sources': [
+      'src/plugin/ActiveQueue.h',
       'src/plugin/AdblockPlus.def',
       'src/plugin/AdblockPlus.idl',
       'src/plugin/AdblockPlus.rc',
@@ -125,12 +126,11 @@
       'src/plugin/Config.h',
       'src/plugin/NotificationMessage.cpp',
       'src/plugin/NotificationMessage.h',
+      'src/plugin/Placeholder.h',
       'src/plugin/Plugin.cpp',
       'src/plugin/Plugin.h',
       'src/plugin/PluginClass.cpp',
       'src/plugin/PluginClass.h',
-      'src/plugin/PluginClientBase.cpp',
-      'src/plugin/PluginClientBase.h',
       'src/plugin/PluginClientFactory.cpp',
       'src/plugin/PluginClientFactory.h',
       'src/plugin/PluginDebug.cpp',
@@ -247,7 +247,6 @@
       'src/plugin/ATL_Deprecate.cpp',
       'src/plugin/NotificationMessage.cpp',
       'src/plugin/Plugin.cpp',
-      'src/plugin/PluginClientBase.cpp',
       'src/plugin/PluginClientFactory.cpp',
       'src/plugin/PluginClass.cpp',
       'src/plugin/PluginFilter.cpp',
@@ -286,5 +285,33 @@
         ]],
       },
     },
-  }]
+  },
+
+  {
+    'target_name': 'tests_plugin_2',
+    'type': 'executable',
+    'dependencies': [
+      'libadblockplus/third_party/googletest.gyp:googletest_main',
+    ],
+    'sources': [
+      'src/plugin/ActiveQueue.h',
+      'src/plugin/Placeholder.h',
+      'test/plugin/ActiveQueueTest.cpp',
+      'test/plugin/PlaceholderTest.cpp',
+    ],
+    'defines': [
+    ],
+    'link_settings': {
+      'libraries': [],
+    },
+    #'msbuild_toolset': 'v140',

[Oleksandr, 2016/01/28 10:15:33]

Nit: Is this some test code commented out? Looks confusing here, IMO.

[Eric, 2016/02/04 21:01:43]

Not so much test code as needed during development. Getting a move-only class to
work right meant temporarily upgrading the compiler to support "= delete" on
copy constructors.

Perhaps more importantly, I'm not sure we need to retain a second unit test
project here. I needed it so that I could use a different compiler (which was,
for reasons I've forgotten, problematic on the first unit test project). It does
have some utility in segregating out the thread-heavy unit tests from the rest,
since when these unit tests crash, they crash hard.

+    'msvs_settings': {
+      'VCLinkerTool': {
+        'SubSystem': '1', # Console
+        'EntryPointSymbol': 'mainCRTStartup',
+      },
+    },
+  },
+  
+  ]
 }