Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(340)

Issue 29324393: Issue 2928 - Add favicon [acceptableads.org] (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by saroyanm
Modified:
4 years, 3 months ago
Reviewers:
Thomas Greiner
CC:
Felix Dahlke
Visibility:
Public.

Description

Issue 2928 - Add favicon [acceptableads.org]

Patch Set 1 #

Total comments: 2

Patch Set 2 : Made consistent with ABP.org #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pages/index.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A static/images/favicon-large.png View 1 Binary file 0 comments Download

Messages

Total messages: 4
saroyanm
Thomas can you also review this, similar to previous review. Aligned with Sven we need ...
4 years, 3 months ago (2015-08-19 16:28:59 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29324393/diff/29324394/pages/index.html File pages/index.html (right): https://codereview.adblockplus.org/29324393/diff/29324394/pages/index.html#newcode12 pages/index.html:12: <link rel="icon" href="/images/favicon.png" /> In https://codereview.adblockplus.org/29324389/ you were using ...
4 years, 3 months ago (2015-08-20 10:08:54 UTC) #2
saroyanm
New patch uploaded https://codereview.adblockplus.org/29324393/diff/29324394/pages/index.html File pages/index.html (right): https://codereview.adblockplus.org/29324393/diff/29324394/pages/index.html#newcode12 pages/index.html:12: <link rel="icon" href="/images/favicon.png" /> On 2015/08/20 ...
4 years, 3 months ago (2015-08-20 12:30:19 UTC) #3
Thomas Greiner
4 years, 3 months ago (2015-08-20 14:46:00 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5