Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29324472: Issue 2523 - Fixed: Search input text invisible in Firefox on small screens (Closed)

Created:
Aug. 20, 2015, 2:41 p.m. by Thomas Greiner
Modified:
Aug. 20, 2015, 3:38 p.m.
Reviewers:
saroyanm
Visibility:
Public.

Description

Issue 2523 - Fixed: Search input text invisible in Firefox on small screens

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M static/css/main-mobile.css View 1 chunk +6 lines, -6 lines 2 comments Download

Messages

Total messages: 3
Thomas Greiner
Aug. 20, 2015, 2:43 p.m. (2015-08-20 14:43:38 UTC) #1
saroyanm
LGTM https://codereview.adblockplus.org/29324472/diff/29324473/static/css/main-mobile.css File static/css/main-mobile.css (left): https://codereview.adblockplus.org/29324472/diff/29324473/static/css/main-mobile.css#oldcode109 static/css/main-mobile.css:109: padding: 16px 10px; I assume it's just consistency ...
Aug. 20, 2015, 2:50 p.m. (2015-08-20 14:50:27 UTC) #2
Thomas Greiner
Aug. 20, 2015, 3:12 p.m. (2015-08-20 15:12:21 UTC) #3
https://codereview.adblockplus.org/29324472/diff/29324473/static/css/main-mob...
File static/css/main-mobile.css (left):

https://codereview.adblockplus.org/29324472/diff/29324473/static/css/main-mob...
static/css/main-mobile.css:109: padding: 16px 10px;
On 2015/08/20 14:50:27, saroyanm wrote:
> I assume it's just consistency change nothing connected to the issue itself.

That as well but the main reason is that since using "border-box" includes the
padding in the box height calculation, this is no longer the case for
"content-box". Therefore the padding needs to be reduced to avoid increasing its
height.

Powered by Google App Engine
This is Rietveld