Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(320)

Issue 29324503: Issue 2936 - Support syntax for duplicate translatable strings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by kzar
Modified:
4 years, 3 months ago
CC:
saroyanm
Visibility:
Public.

Description

Issue 2936 - Support syntax for duplicate translatable strings

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove misleading variable #

Total comments: 7

Patch Set 3 : Re-do logic for storing "seen strings" #

Patch Set 4 : Store comment for previously seen strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M cms/converters.py View 1 2 3 3 chunks +19 lines, -7 lines 0 comments Download

Messages

Total messages: 9
kzar
Patch Set 1
4 years, 3 months ago (2015-08-21 09:49:17 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29324503/diff/29324504/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29324503/diff/29324504/cms/converters.py#newcode137 cms/converters.py:137: duplicate_string = not default Nit: I find this variable ...
4 years, 3 months ago (2015-08-23 14:24:13 UTC) #2
kzar
Patch Set 2 : Remove misleading variable https://codereview.adblockplus.org/29324503/diff/29324504/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29324503/diff/29324504/cms/converters.py#newcode137 cms/converters.py:137: duplicate_string = ...
4 years, 3 months ago (2015-08-23 15:28:53 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29324503/diff/29324516/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29324503/diff/29324516/cms/converters.py#newcode142 cms/converters.py:142: default = self._params["localedata"][name] This logic is wrong, the default ...
4 years, 3 months ago (2015-08-24 11:07:18 UTC) #4
kzar
Patch Set 3 : Re-do logic for storing "seen strings" https://codereview.adblockplus.org/29324503/diff/29324516/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29324503/diff/29324516/cms/converters.py#newcode142 ...
4 years, 3 months ago (2015-08-24 14:29:46 UTC) #5
Wladimir Palant
https://codereview.adblockplus.org/29324503/diff/29324516/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29324503/diff/29324516/cms/converters.py#newcode162 cms/converters.py:162: if default: On 2015/08/24 14:29:45, kzar wrote: > Well ...
4 years, 3 months ago (2015-08-24 15:00:22 UTC) #6
kzar
Patch Set 4 : Store comment for previously seen strings
4 years, 3 months ago (2015-08-24 15:12:13 UTC) #7
Wladimir Palant
LGTM I had a few nits but these are already present in the original code.
4 years, 3 months ago (2015-08-24 15:17:06 UTC) #8
Sebastian Noack
4 years, 3 months ago (2015-08-24 15:39:09 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5