Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29324553: Issue 2909 - Allow for adjusting the location of $hgweb::templates (Closed)

Created:
Aug. 24, 2015, 5:36 p.m. by mathias
Modified:
Oct. 12, 2015, 10:05 a.m.
Reviewers:
Felix Dahlke
CC:
Fred, Wladimir Palant
Visibility:
Public.

Description

Issue 2909 - Allow for adjusting the location of $hgweb::templates

Patch Set 1 #

Total comments: 2

Patch Set 2 : Issue 2909 - Updated documentation and rebased on top of upstream #

Patch Set 3 : Issue 2909 - Removed .patch fragment included by accident #

Patch Set 4 : Issue 2909 - Removed *.orig fragment included by accident #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -31 lines) Patch
D modules/hgweb/files/nginx.conf View 1 1 chunk +0 lines, -30 lines 0 comments Download
M modules/hgweb/manifests/init.pp View 1 2 chunks +5 lines, -0 lines 0 comments Download
A + modules/hgweb/templates/nginx.conf.erb View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13
mathias
Aug. 24, 2015, 5:36 p.m. (2015-08-24 17:36:41 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29324553/diff/29324554/modules/hgweb/manifests/init.pp File modules/hgweb/manifests/init.pp (right): https://codereview.adblockplus.org/29324553/diff/29324554/modules/hgweb/manifests/init.pp#newcode37 modules/hgweb/manifests/init.pp:37: $templates = hiera('hgweb::templates', '/usr/share/mercurial/templates'), I might have said this ...
Aug. 24, 2015, 6:37 p.m. (2015-08-24 18:37:02 UTC) #2
mathias
https://codereview.adblockplus.org/29324553/diff/29324554/modules/hgweb/manifests/init.pp File modules/hgweb/manifests/init.pp (right): https://codereview.adblockplus.org/29324553/diff/29324554/modules/hgweb/manifests/init.pp#newcode37 modules/hgweb/manifests/init.pp:37: $templates = hiera('hgweb::templates', '/usr/share/mercurial/templates'), On 2015/08/24 18:37:02, Wladimir Palant ...
Aug. 24, 2015, 7:03 p.m. (2015-08-24 19:03:08 UTC) #3
Felix Dahlke
On 2015/08/24 19:03:08, mathias wrote: > https://codereview.adblockplus.org/29324553/diff/29324554/modules/hgweb/manifests/init.pp > File modules/hgweb/manifests/init.pp (right): > > https://codereview.adblockplus.org/29324553/diff/29324554/modules/hgweb/manifests/init.pp#newcode37 > ...
Sept. 25, 2015, 3:40 p.m. (2015-09-25 15:40:01 UTC) #4
Felix Dahlke
On 2015/09/25 15:40:01, Felix Dahlke wrote: > On 2015/08/24 19:03:08, mathias wrote: > > > ...
Oct. 1, 2015, 6:46 a.m. (2015-10-01 06:46:28 UTC) #5
mathias
> Do I understand it correctly that we're not using the Mercurial installed by Puppet, ...
Oct. 1, 2015, 7:04 a.m. (2015-10-01 07:04:07 UTC) #6
Felix Dahlke
On 2015/10/01 07:04:07, mathias wrote: > It is a requirement for the hg-git version in ...
Oct. 1, 2015, 8:37 a.m. (2015-10-01 08:37:10 UTC) #7
mathias
> OK, follow-up question: Couldn't we install the Mercurial version we need > through Puppet? ...
Oct. 1, 2015, 8:51 a.m. (2015-10-01 08:51:53 UTC) #8
Felix Dahlke
On 2015/10/01 08:51:53, mathias wrote: > > OK, follow-up question: Couldn't we install the Mercurial ...
Oct. 1, 2015, 9:05 a.m. (2015-10-01 09:05:03 UTC) #9
mathias
Follow-up: https://issues.adblockplus.org/ticket/3145
Oct. 1, 2015, 12:02 p.m. (2015-10-01 12:02:05 UTC) #10
mathias
Oct. 1, 2015, 12:03 p.m. (2015-10-01 12:03:19 UTC) #11
mathias
Oct. 1, 2015, 12:04 p.m. (2015-10-01 12:04:19 UTC) #12
Felix Dahlke
Oct. 12, 2015, 8:10 a.m. (2015-10-12 08:10:13 UTC) #13
LGTM (Anyone reading this, see my last comment however - we should solve this
properly at some point.)

Powered by Google App Engine
This is Rietveld