Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: README.md

Issue 29324576: Issue 2599, 2940 - Fix the presence of correct ATL version (Closed)
Patch Set: Created Aug. 25, 2015, 1:11 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | adblockplus.gyp » ('j') | adblockplus.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: README.md
===================================================================
--- a/README.md
+++ b/README.md
@@ -17,8 +17,11 @@
--------
You need Microsoft Visual C++ 2012 and Python 2.7. Make sure that `python.exe`
-is on your `PATH`. Unfortunately until we move to Visual Studio 2013 you'll
-need to use Visual Studio 2012 version that comes with ATL (Proffessional etc).
+is on your `PATH`. When building with Express edition you also need some
+Visual Studio which comes with ATL. For example, if you use Visual Studio 2013
+Community Edition then set `VCInstallDir_120` environment variable to the
+directory of Visual C++ (for example,
+`C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC`).
Eric 2015/08/26 18:25:35 This comment does not explain things adequately.
sergei 2015/08/26 21:47:54 Do you mean that user does not know about absence
* Execute `createsolution.bat` to retrieve dependencies and generate project
files, this will create `build\ia32\adblockplus.sln` (solution for the 32 bit
« no previous file with comments | « no previous file | adblockplus.gyp » ('j') | adblockplus.gyp » ('J')

Powered by Google App Engine
This is Rietveld