Issue 2394 - Added unit tests for CSS property filters

chrome/content/tests/cssRules.js

 (function()
 {
   module("CSS property filter", {
     setup: function()
     {
       prepareFilterComponents.call(this);
       preparePrefs.call(this);
     },
     teardown: function()
     {
@@ skipping 37 matching lines @@
   function compareRules(text, domain, expected)
   {
     let result = CSSRules.getRulesForDomain(domain)
         .map((filter) => filter.text);
     expected = expected.map((filter) => filter.text);
     deepEqual(result.sort(), expected.sort(), text);
   }
 
   test("CSS property filters container", function()
   {
-    let genericFilter = Filter.fromText("##filter1");

[Wladimir Palant, 2015/12/04 13:09:48]

This comment hasn't been addressed from the previous review:
We shouldn't be testing implementation details.

[Thomas Greiner, 2015/12/07 17:29:26]

Done.

-    let domainFilter = Filter.fromText("example.com##filter2");
-    let subdomainFilter = Filter.fromText("www.example.com##filter3");
-    let otherDomainFilter = Filter.fromText("other.example.com##filter4");
+    let domainFilter = Filter.fromText("example.com##filter1");
+    let subdomainFilter = Filter.fromText("www.example.com##filter2");
+    let otherDomainFilter = Filter.fromText("other.example.com##filter3");
 
-    CSSRules.add(genericFilter);
     CSSRules.add(domainFilter);
     CSSRules.add(subdomainFilter);
     CSSRules.add(otherDomainFilter);
     compareRules("Return all matching filters", "www.example.com",
-        [genericFilter, domainFilter, subdomainFilter]);
+        [domainFilter, subdomainFilter]);
 
-    CSSRules.remove(genericFilter);
+    CSSRules.remove(domainFilter);
     compareRules("Return all matching filters after removing one",
-        "www.example.com", [domainFilter, subdomainFilter]);
+        "www.example.com", [subdomainFilter]);
 
     CSSRules.clear();
     compareRules("Return no filters after clearing", "www.example.com", []);
   });
 })();