Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29324625: Issue 2951 - Fix handling of URLs without a scheme (Closed)

Created:
Aug. 25, 2015, 8:25 p.m. by Wladimir Palant
Modified:
Oct. 12, 2015, 11:32 a.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

See https://issues.adblockplus.org/ticket/2951#comment:2 for a description of the problem here.

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M run.py View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Aug. 25, 2015, 8:25 p.m. (2015-08-25 20:25:34 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29324625/diff/29324626/run.py File run.py (right): https://codereview.adblockplus.org/29324625/diff/29324626/run.py#newcode49 run.py:49: fullurl = data['url'] if ':' in data['url'] else 'http://' ...
Aug. 26, 2015, 1:11 p.m. (2015-08-26 13:11:52 UTC) #2
Wladimir Palant
I somehow forgot this review, addressed comments now. https://codereview.adblockplus.org/29324625/diff/29324626/run.py File run.py (right): https://codereview.adblockplus.org/29324625/diff/29324626/run.py#newcode49 run.py:49: fullurl ...
Oct. 9, 2015, 10:27 a.m. (2015-10-09 10:27:35 UTC) #3
Sebastian Noack
Oct. 9, 2015, 10:33 a.m. (2015-10-09 10:33:16 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld