Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: mobile/android/base/tabs/TabStripView.java

Issue 29325252: Issue 2932 - Show the dividers between all tabs (Closed)
Patch Set: Created Aug. 28, 2015, 9:13 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mobile/android/base/tabs/TabStripView.java
===================================================================
--- a/mobile/android/base/tabs/TabStripView.java
+++ b/mobile/android/base/tabs/TabStripView.java
@@ -388,11 +388,16 @@
final boolean pressed = (child.isPressed() || getChildAt(i - 1).isPressed());
final boolean checked = (i == checkedIndex || i == checkedIndex + 1);
+ // We don't show the tab curves in Adblock Browser, so we always
+ // want to draw the dividers.
+ // See https://issues.adblockplus.org/ticket/2932.
+ /*
// Don't draw dividers for around checked or pressed items
// so that they are not drawn on top of the tab curves.
if (pressed || checked) {
continue;
}
+ */
final int left = child.getLeft() - (itemMargin / 2) - dividerWidth;
final int right = left + dividerWidth;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld