Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1195)

Issue 29325371: Issue 2822 - Added support for new subscription types (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by Thomas Greiner
Modified:
3 years, 10 months ago
Reviewers:
Sebastian Noack
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 2822 - Added support for new subscription types

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M sitescripts/subscriptions/subscriptionParser.py View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M sitescripts/subscriptions/template/recommendations.xml View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6
Thomas Greiner
3 years, 10 months ago (2015-08-28 17:44:11 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29325371/diff/29325372/sitescripts/subscriptions/subscriptionParser.py File sitescripts/subscriptions/subscriptionParser.py (right): https://codereview.adblockplus.org/29325371/diff/29325372/sitescripts/subscriptions/subscriptionParser.py#newcode204 sitescripts/subscriptions/subscriptionParser.py:204: if self.recommendation != None and self.type == 'ads' and ...
3 years, 10 months ago (2015-08-31 11:41:06 UTC) #2
Thomas Greiner
https://codereview.adblockplus.org/29325371/diff/29325372/sitescripts/subscriptions/subscriptionParser.py File sitescripts/subscriptions/subscriptionParser.py (right): https://codereview.adblockplus.org/29325371/diff/29325372/sitescripts/subscriptions/subscriptionParser.py#newcode204 sitescripts/subscriptions/subscriptionParser.py:204: if self.recommendation != None and self.type == 'ads' and ...
3 years, 10 months ago (2015-08-31 15:27:47 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29325371/diff/29325397/sitescripts/subscriptions/subscriptionParser.py File sitescripts/subscriptions/subscriptionParser.py (right): https://codereview.adblockplus.org/29325371/diff/29325397/sitescripts/subscriptions/subscriptionParser.py#newcode196 sitescripts/subscriptions/subscriptionParser.py:196: if self.type not in ['ads', 'anti-adblock', 'other', 'malware', 'social', ...
3 years, 10 months ago (2015-08-31 15:53:44 UTC) #4
Thomas Greiner
https://codereview.adblockplus.org/29325371/diff/29325397/sitescripts/subscriptions/subscriptionParser.py File sitescripts/subscriptions/subscriptionParser.py (right): https://codereview.adblockplus.org/29325371/diff/29325397/sitescripts/subscriptions/subscriptionParser.py#newcode196 sitescripts/subscriptions/subscriptionParser.py:196: if self.type not in ['ads', 'anti-adblock', 'other', 'malware', 'social', ...
3 years, 10 months ago (2015-09-02 14:10:19 UTC) #5
Sebastian Noack
3 years, 10 months ago (2015-09-02 15:00:34 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5