hiera/roles/buildmasterserver.yaml - Issue 29325436: Issue 1281 - Introduce module buildbot

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: hiera/roles/buildmasterserver.yaml

Issue 29325436: Issue 1281 - Introduce module buildbot (Closed)

Patch Set: Issue 1281 - Address review feedback Created Oct. 20, 2015, 8:35 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 classes:

	2 adblockplus::buildmaster:

	3 domain: buildbot.adblockplus.org
	Felix Dahlke 2015/11/19 19:50:00 I'm wondering if build.adblockplus.org wouldn't be I'm wondering if build.adblockplus.org wouldn't be better. That's more in line with our other purpose-specific URLs (issues.adblockplus, codereview.adblockplus.org etc.), and it seems to be the most popular choice among prominent Buildbot users (such as Chromium and WebKit), too. mathias 2016/01/20 16:13:51 Acknowledged; but I'll use the plural form ("build Show quoted text On 2015/11/19 19:50:00, Felix Dahlke wrote: > I'm wondering if http://build.adblockplus.org wouldn't be better. That's more in line > with our other purpose-specific URLs (issues.adblockplus, > http://codereview.adblockplus.org etc.), and it seems to be the most popular choice > among prominent Buildbot users (such as Chromium and WebKit), too. Acknowledged; but I'll use the plural form ("builds").
	4 is_default_domain: true

	5 project:

	6 title: Adblock Plus

	7 url: https://adblockplus.org/

	8

OLD	NEW