modules/adblockplus/files/nginx/buildmaster.conf - Issue 29325436: Issue 1281 - Introduce module buildbot

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: modules/adblockplus/files/nginx/buildmaster.conf

Issue 29325436: Issue 1281 - Introduce module buildbot (Closed)

Patch Set: Issue 1281 - Address review feedback Created Oct. 20, 2015, 8:35 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
	1 # Forward requests to the local builbot master
	Felix Dahlke 2015/11/19 19:50:00 Am I missing something, or does modules/adblockplu Am I missing something, or does modules/adblockplus/files/nginx/buildmaster.conf not actually exist in the repository? mathias 2016/01/20 16:13:51 It seems like an entity in the review-tool-chain ( Show quoted text On 2015/11/19 19:50:00, Felix Dahlke wrote: > Am I missing something, or does modules/adblockplus/files/nginx/buildmaster.conf > not actually exist in the repository? It seems like an entity in the review-tool-chain (SCM/diff, upload.py or Rietveld) assumes that this file is related to modules/rietveld/files/site.conf - simply because they are almost identical - and thus diff's against it. Still, they have nothing to do with each other, so this is just a display issue here.
1 location /	2 location /

2 {	3 {

3 proxy_pass http://localhost:8080/;	4 proxy_pass http://127.0.0.1:8010/;

4 proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;	5 proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;

5 proxy_set_header X-Real-IP $remote_addr;	6 proxy_set_header X-Real-IP $remote_addr;

6 proxy_set_header X-Forwarded-Proto $scheme;	7 proxy_set_header X-Forwarded-Proto $scheme;

7 proxy_set_header Host $http_host;	8 proxy_set_header Host $http_host;

8 }	9 }

	10

OLD	NEW