Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Delta Between Two Patch Sets: hiera/roles/buildmasterserver.yaml
Issue
29325436
:
Issue 1281 - Introduce module buildbot (Closed)
Left Patch Set: Issue 1281 - Rebase branch buildbot on top of upstream
Created Sept. 5, 2015, 11:27 p.m.
Right Patch Set: Issue 1281 - Fix documentation, improve configuration parameter handling
Created Jan. 20, 2016, 4:13 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Issue 1281 - Rebase branch buildbot on top of upstream
Patch Set 3: Issue 1281 - Address review feedback
Patch Set 4: Issue 1281 - Fix documentation, improve configuration parameter handling
Right:
Patch Set 1: None
Patch Set 2: Issue 1281 - Rebase branch buildbot on top of upstream
Patch Set 3: Issue 1281 - Address review feedback
Patch Set 4: Issue 1281 - Fix documentation, improve configuration parameter handling
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
hiera/roles/buildmasterserver.yaml
modules/adblockplus/files/nginx/buildmaster.conf
modules/adblockplus/manifests/buildmaster.pp
modules/adblockplus/templates/buildmaster.erb
modules/buildbot/manifests/fragment.pp
modules/buildbot/manifests/init.pp
modules/buildbot/manifests/master.pp
modules/buildbot/manifests/slave.pp
modules/buildbot/templates/buildmaster.erb
modules/buildbot/templates/buildmaster_fragment.erb
modules/buildbot/templates/buildslave.erb
modules/buildbot/templates/buildslave_fragment.erb
modules/buildbot/templates/master.cfg.erb
modules/private-stub/hiera/hosts.yaml
Right:
Side by side diff
|
Download
« no previous file with change/comment
|
« no previous file
|
modules/adblockplus/files/nginx/buildmaster.conf »
('j') |
modules/buildbot/templates/master.cfg.erb »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
LEFT
RIGHT
(no file at all)
1
classes:
2
adblockplus::buildmaster:
3
domain: builds.adblockplus.org
4
is_default_domain: true
5
buildbot_config:
6
title: Adblock Plus
7
titleURL: https://adblockplus.org/
8
LEFT
RIGHT
« no previous file
|
modules/adblockplus/files/nginx/buildmaster.conf »
('j') |
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Toggle Comments
('s')
Edit Message
Issue 29325436: Issue 1281 - Introduce module buildbot (Closed)
Created Sept. 1, 2015, 1:30 p.m. by mathias
Modified Feb. 20, 2016, 1:25 p.m.
Reviewers: Felix Dahlke
Base URL:
Comments: 69
This is Rietveld