Issue 2967 - Show about:feedback automatically

mobile/android/base/BrowserApp.java

 /* -*- Mode: Java; c-basic-offset: 4; tab-width: 4; indent-tabs-mode: nil; -*-
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 package org.mozilla.gecko;
 
 import org.mozilla.gecko.AppConstants.Versions;
 import org.mozilla.gecko.DynamicToolbar.PinReason;
 import org.mozilla.gecko.DynamicToolbar.VisibilityTransition;
@@ skipping 214 matching lines @@
         @Override
         public float getInterpolation(float t) {
             t -= 1.0f;
             return t * t * t * t * t + 1.0f;
         }
     };
 
     private FindInPageBar mFindInPageBar;
     private MediaCastingBar mMediaCastingBar;
 
-    // Don't show about:feedback automatically in Adblock Browser, see
-    // https://issues.adblockplus.org/ticket/2521
-    private static final int FEEDBACK_LAUNCH_COUNT = 0;
+    // We again show about:feedback automatically in Adblock Browser, after
+    // 5 application starts, but only for installations from the PlayStore,
+    // see https://issues.adblockplus.org/ticket/2967
+    private static final int FEEDBACK_LAUNCH_COUNT = 5;
 
     // Stored value of the toolbar height, so we know when it's changed.
     private int mToolbarHeight;
 
     // Stored value of whether the last metrics change allowed for toolbar
     // scrolling.
     private boolean mDynamicToolbarCanScroll;
 
     private SharedPreferencesHelper mSharedPreferencesHelper;
 
@@ skipping 3287 matching lines @@
         // Faster on main thread with an async apply().
         try {
             SharedPreferences settings = getPreferences(Activity.MODE_PRIVATE);
             int launchCount = settings.getInt(keyName, 0);
             if (launchCount < FEEDBACK_LAUNCH_COUNT) {
                 // Increment the launch count and store the new value.
                 launchCount++;
                 settings.edit().putInt(keyName, launchCount).apply();
 
                 // If we've reached our magic number, show the feedback page.
-                if (launchCount == FEEDBACK_LAUNCH_COUNT) {
+                if (launchCount == FEEDBACK_LAUNCH_COUNT && wasInstalledFromPlayStore()) {
                     GeckoAppShell.sendEventToGecko(GeckoEvent.createBroadcastEvent("Feedback:Show", null));
                 }
             }
         } finally {
             StrictMode.setThreadPolicy(savedPolicy);
         }
     }
 
+    private boolean wasInstalledFromPlayStore() {
+        final String installer = this.getPackageManager().getInstallerPackageName(this.getPackageName());
+        return "com.android.vending".equals(installer);
+    }
+
     private void showTabQueuePromptIfApplicable(final Intent intent) {
         ThreadUtils.postToBackgroundThread(new Runnable() {
             @Override
             public void run() {
                 // We only want to show the prompt if the browser has been opened from an external url
                 if (AppConstants.NIGHTLY_BUILD && AppConstants.MOZ_ANDROID_TAB_QUEUE
                                                && mInitialized
                                                && Intent.ACTION_VIEW.equals(intent.getAction())
                                                && TabQueueHelper.shouldShowTabQueuePrompt(BrowserApp.this)) {
                     Intent promptIntent = new Intent(BrowserApp.this, TabQueuePrompt.class);
@@ skipping 227 matching lines @@
                                          dispatcher,
                                          osLocale,
                                          appLocale,
                                          previousSession);
     }
 
     public static interface Refreshable {
         public void refresh();
     }
 }