2 - Issue 29325845: Restrict browser promotion to Firefox and Chrome

Side by Side Diff: 2

Issue 29325845: Restrict browser promotion to Firefox and Chrome (Closed)

Patch Set: Created Sept. 3, 2015, 3:53 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | no next file » | no next file with comments »

OLD	NEW
1 severity = information	1 severity = information

2 target = extension=adblockplus	2 target = extension=adblockplus application=firefox

3 target = extension=adblockpluschrome	3 target = extension=adblockpluschrome application=chrome
	Sebastian Noack 2015/09/03 16:10:29 So we don't want to show the notification on Opera So we don't want to show the notification on Opera and Safari? Please explain. Felix Dahlke 2015/09/03 16:11:59 Doesn't seem worth the trouble, we didn't test thi Show quoted text On 2015/09/03 16:10:29, Sebastian Noack wrote: > So we don't want to show the notification on Opera and Safari? Please explain. Doesn't seem worth the trouble, we didn't test this, I'm not even sure we have an opt-out in Safari. Note that extension=adblockpluschrome should already achieve that, this patch shouldn't change anything about that. Sebastian Noack 2015/09/03 16:15:36 Yes, we have the opt-out on Safari. The UI is the Show quoted text On 2015/09/03 16:11:59, Felix Dahlke wrote: > On 2015/09/03 16:10:29, Sebastian Noack wrote: > > So we don't want to show the notification on Opera and Safari? Please explain. > > Doesn't seem worth the trouble, we didn't test this, I'm not even sure we have > an opt-out in Safari. Note that extension=adblockpluschrome should already > achieve that, this patch shouldn't change anything about that. Yes, we have the opt-out on Safari. The UI is the same as on Chrome. But you are right, the extension name already excludes Opera and Safari anyway. It's a shame though, as presumably Safari and theirfore OS X users often have iPhones as well. But if we didn't test that yet, it's too late now. :(
4 start = 2015-09-01T13:00	4 start = 2015-09-01T13:00

5 end = 2015-09-08T13:00	5 end = 2015-09-08T13:00

6	6

7 [1]	7 [1]

8 sample = 0.003	8 sample = 0.003

9 links = adblock_browser_promotion_1	9 links = adblock_browser_promotion_1

10	10

11 title.en-US = Love Adblock Plus?	11 title.en-US = Love Adblock Plus?

12 title.de = Du bist Adblock Plus Fan?	12 title.de = Du bist Adblock Plus Fan?

13 title.ru = Нравится Adblock Plus?	13 title.ru = Нравится Adblock Plus?

(...skipping 384 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
398 message.et = Nautige Adblock Browseri abil nutitelefonis ja tahvelarvutis samasu gust reklaamivaba sirvimist.	398 message.et = Nautige Adblock Browseri abil nutitelefonis ja tahvelarvutis samasu gust reklaamivaba sirvimist.

399 message.lv = Saņem to pašu bez reklāmu pārlūkošanu viedtālrunī vai planšetdatorā ar Adblock pārlūku.	399 message.lv = Saņem to pašu bez reklāmu pārlūkošanu viedtālrunī vai planšetdatorā ar Adblock pārlūku.

400 message.lt = Gaukite tokią pačią nemokamą programą naršymui savo išmaniajame tel efone ar planšetėje su Adblock naršykle.	400 message.lt = Gaukite tokią pačią nemokamą programą naršymui savo išmaniajame tel efone ar planšetėje su Adblock naršykle.

401 message.be = Працуйце на сваім смартфоне або планшэце без рэкламы з дапамогай бр аўзэра Аdblock.	401 message.be = Працуйце на сваім смартфоне або планшэце без рэкламы з дапамогай бр аўзэра Аdblock.

402 message.kk = Adblock Browser арқылы смартфонда немесе планшетте бұрынғыдай жарна масыз шолу мүмкіндігін алыңыз.	402 message.kk = Adblock Browser арқылы смартфонда немесе планшетте бұрынғыдай жарна масыз шолу мүмкіндігін алыңыз.

403 message.nb-NO = Få den samme annonsefrie surfingen på din smarttelefon eller dit t nettbrett med Adblock Browser.	403 message.nb-NO = Få den samme annonsefrie surfingen på din smarttelefon eller dit t nettbrett med Adblock Browser.

404 message.is = Vafraðu með sama hætti auglýsingalaust á snjallsímanum og á spjaldt ölvunni þinni með Adblock-vafranum.	404 message.is = Vafraðu með sama hætti auglýsingalaust á snjallsímanum og á spjaldt ölvunni þinni með Adblock-vafranum.

405 message.ca = Aconsegueix la mateixa navegació sense publicitat en el teu telèfon intel·ligent o tauleta amb Adblock Browser.	405 message.ca = Aconsegueix la mateixa navegació sense publicitat en el teu telèfon intel·ligent o tauleta amb Adblock Browser.

406 message.eu = Adblock Bilatzailearekin orain arte bezalako bilaketak egin ahal iz ango dituzu erabat dohan zure smartphone edo tabletan.	406 message.eu = Adblock Bilatzailearekin orain arte bezalako bilaketak egin ahal iz ango dituzu erabat dohan zure smartphone edo tabletan.

407 message.af = Kry dieselfde advertensievrye webblaai op jou slimfoon of tablet me t Adblock Blaaier.	407 message.af = Kry dieselfde advertensievrye webblaai op jou slimfoon of tablet me t Adblock Blaaier.

OLD	NEW