pages/testcases/generic/index.html - Issue 29325987: Issue 616 - Add some tests for generic hide + block

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: pages/testcases/generic/index.html

Issue 29325987: Issue 616 - Add some tests for generic hide + block (Closed)

Left Patch Set: Created Sept. 5, 2015, 3:27 p.m.

Right Patch Set: Adjust for new dimensions of test + fail images Created Sept. 11, 2015, 2:14 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 title=ABP Test Pages	1 title=ABP Test Pages

2 template=blank	2 template=blank

3	3

4 <head>	4 <head>

5 <style>	5 <style>

6 html, body { margin: 0; height: 100%; }	6 html, body { margin: 0; height: 100%; }

7 #iframe { display: block; width: 100%; height: 100%; border: none; }	7 #iframe { display: block; width: 100%; height: 100%; border: none; }

8 </style>	8 </style>

9 </head>	9 </head>

10	10

11 <iframe id="iframe"></iframe>	11 <iframe id="iframe"></iframe>
kzar 2015/09/05 15:36:53 I've created this page so that we can load test ca I've created this page so that we can load test cases inside a frame with a different domain (www.testcases.adblockplus.org as opposed to testcases.adblockplus.org). I wanted to do this to make sure that the filters were applying recursively through frames. I wanted to place this file in pages/index.html so that it could be easily re-used elsewhere but unfortunately that wasn't possible with the filter matching tests I wanted to do. That said we could still copy this file and place it in other testcases directories if we need to test recursive matching elsewhere. (Perhaps using an include to reduce duplication.) rossg 2015/09/10 11:06:08 I applied the patch set successfully, however some Show quoted text On 2015/09/05 15:36:53, kzar wrote: > snip I applied the patch set successfully, however sometimes the pages do not load correctly for me. They fail because they are attempting to lookup www.www.testcases.adblockplus.org or www.www.www.testcases.adblockplus.org. So far I figured out the failure to load is due to links on the main testpages index page having www. in front of them, leading to the replace creating the double or triple www. links. However sometimes when loading the index page, it's fine. I'm testing with both testpages.adblockplus.org and www.testpages.adblockplus.org pointing at a local server at 127.0.0.1:5000. kzar 2015/09/10 11:12:06 My mistake, should be fixed now for both www.testp Show quoted text On 2015/09/10 11:06:08, rossg wrote: > On 2015/09/05 15:36:53, kzar wrote: > > snip > > I applied the patch set successfully, however sometimes the pages do not load > correctly for me. They fail because they are attempting to lookup > http://www.www.testcases.adblockplus.org or http://www.www.www.testcases.adblockplus.org. So > far I figured out the failure to load is due to links on the main testpages > index page having www. in front of them, leading to the replace creating the > double or triple www. links. However sometimes when loading the index page, it's > fine. > > I'm testing with both http://testpages.adblockplus.org and > http://www.testpages.adblockplus.org pointing at a local server at 127.0.0.1:5000. > My mistake, should be fixed now for both www.testpages... and testpages...
12	12

13 <script type="text/javascript">	13 <script type="text/javascript">

14 var iframe = document.getElementById("iframe")	14 var iframe = document.getElementById("iframe")

15 function update_iframe_location()	15 function update_iframe_location()

16 {	16 {

17 var hash = window.location.hash;	17 var hash = window.location.hash;

18 if (hash)	18 if (hash)

19 {	19 {

20 var url = window.location.href.	20 var url = window.location.href.

21 substr(0, window.location.href.length - hash.length).	21 substr(0, window.location.href.length - hash.length).

22 replace("testpages", "www.testpages") + hash.substring(1);	22 replace("://testpages", "://www.testpages") + hash.substring(1);

23	23

24 iframe.src = url;	24 iframe.src = url;

25 }	25 }

26 }	26 }

27 window.addEventListener("hashchange", update_iframe_location);	27 window.addEventListener("hashchange", update_iframe_location);

28 update_iframe_location();	28 update_iframe_location();

29 </script>	29 </script>

LEFT	RIGHT